Sign upLogin

catarse/catarse.js

View on GitHub
Star
legacy/src/vms/credit-card-vm.js

Summary

Maintainability
D
2 days
Test Coverage

File credit-card-vm.js has 448 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import _ from 'underscore';
import prop from 'mithril/stream';

const { CatarseAnalytics } = window;
Severity: Minor
Found in legacy/src/vms/credit-card-vm.js - About 6 hrs to fix

    Function formatCardInputNumber has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const formatCardInputNumber = (e, cardNumberProp) => {
    let $target,
        card,
        digit,
        length,
    Severity: Minor
    Found in legacy/src/vms/credit-card-vm.js - About 1 hr to fix

      Function validateCardExpiry has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const validateCardExpiry = function (month, year) {
    let currentTime,
        expiry,
        ref;
    if (typeof month === 'object' && 'month' in month) {
      Severity: Minor
      Found in legacy/src/vms/credit-card-vm.js - About 1 hr to fix

        Function safeVal has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        const safeVal = (value, $target, cardNumberProp) => {
    let currPair,
        cursor,
        digit,
        error,
        Severity: Minor
        Found in legacy/src/vms/credit-card-vm.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function validateCardExpiry has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        const validateCardExpiry = function (month, year) {
    let currentTime,
        expiry,
        ref;
    if (typeof month === 'object' && 'month' in month) {
        Severity: Minor
        Found in legacy/src/vms/credit-card-vm.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function safeVal has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const safeVal = (value, $target, cardNumberProp) => {
    let currPair,
        cursor,
        digit,
        error,
        Severity: Minor
        Found in legacy/src/vms/credit-card-vm.js - About 1 hr to fix

          Function hasTextSelected has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          const hasTextSelected = ($target) => {
    let ref;
    if (($target.selectionStart != null) && $target.selectionStart !== $target.selectionEnd) {
        return true;
    }
          Severity: Minor
          Found in legacy/src/vms/credit-card-vm.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function formatCardInputNumber has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          const formatCardInputNumber = (e, cardNumberProp) => {
    let $target,
        card,
        digit,
        length,
          Severity: Minor
          Found in legacy/src/vms/credit-card-vm.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return !!/[\d\s]/.test(input);
          Severity: Major
          Found in legacy/src/vms/credit-card-vm.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return setTimeout(() => $target.value = cardNumberProp(`${value + digit} `));
            Severity: Major
            Found in legacy/src/vms/credit-card-vm.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return false;
              Severity: Major
              Found in legacy/src/vms/credit-card-vm.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return expiry > currentTime;
                Severity: Major
                Found in legacy/src/vms/credit-card-vm.js - About 30 mins to fix

                  Function cardFromNumber has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  const cardFromNumber = (num) => {
    let card,
        i,
        j,
        len,
                  Severity: Minor
                  Found in legacy/src/vms/credit-card-vm.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      } else if (/\s\d?$/.test(value)) {
        e.preventDefault();
        return setTimeout(() => $target.value = cardNumberProp(value.replace(/\d$/, '')));
    }
                  Severity: Minor
                  Found in legacy/src/vms/credit-card-vm.js and 1 other location - About 30 mins to fix
                  legacy/src/vms/credit-card-vm.js on lines 135..141

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (/\d\s$/.test(value)) {
        e.preventDefault();
        return setTimeout(() => $target.value = cardNumberProp(value.replace(/\d\s$/, '')));
    } else if (/\s\d?$/.test(value)) {
        e.preventDefault();
                  Severity: Minor
                  Found in legacy/src/vms/credit-card-vm.js and 1 other location - About 30 mins to fix
                  legacy/src/vms/credit-card-vm.js on lines 138..141

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status