Sign upLogin

catarse/catarse.js

View on GitHub
Star
legacy/src/vms/payment-vm.js

Summary

Maintainability
F
5 days
Test Coverage

Function paymentVM has 372 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const paymentVM = () => {
    const pagarme = prop({}),
        defaultCountryID = addressVM.defaultCountryID,
        submissionError = prop(false),
        isLoading = prop(false);
Severity: Major
Found in legacy/src/vms/payment-vm.js - About 1 day to fix

    Function paymentVM has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

    const paymentVM = () => {
    const pagarme = prop({}),
        defaultCountryID = addressVM.defaultCountryID,
        submissionError = prop(false),
        isLoading = prop(false);
    Severity: Minor
    Found in legacy/src/vms/payment-vm.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File payment-vm.js has 384 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import m from 'mithril';
import prop from 'mithril/stream';
import _ from 'underscore';
import moment, { defaultFormat } from 'moment';
import h from '../h';
    Severity: Minor
    Found in legacy/src/vms/payment-vm.js - About 5 hrs to fix

      Function payWithNewCard has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const payWithNewCard = (contribution_id, installment) => {
        const p = new Promise((resolve, reject) => {
            m.request({
                method: 'GET',
                url: `/payment/pagarme/${contribution_id}/get_encryption_key`,
      Severity: Minor
      Found in legacy/src/vms/payment-vm.js - About 1 hr to fix

        Function p has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const p = new Promise((resolve, reject) => {
            m.request({
                method: 'GET',
                url: `/payment/pagarme/${contribution_id}/get_encryption_key`,
                config: setCsrfToken
        Severity: Minor
        Found in legacy/src/vms/payment-vm.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const kondutoExecute = function () {
        const customerID = h.getUserID();

        if (customerID) {
            var period = 300;
          Severity: Major
          Found in legacy/src/vms/payment-vm.js and 1 other location - About 6 hrs to fix
          legacy/src/vms/common-payment-vm.js on lines 172..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 155.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const resetFieldError = fieldName => () => {
        const errors = fields.errors(),
            errorField = _.findWhere(fields.errors(), { field: fieldName }),
            newErrors = _.compose(fields.errors, _.without);
          Severity: Major
          Found in legacy/src/vms/payment-vm.js and 1 other location - About 2 hrs to fix
          legacy/src/vms/payment-vm.js on lines 394..400

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const resetCreditCardFieldError = fieldName => () => {
        const errors = fields.errors(),
            errorField = _.findWhere(creditCardFields.errors(), { field: fieldName }),
            newErrors = _.compose(creditCardFields.errors, _.without);
          Severity: Major
          Found in legacy/src/vms/payment-vm.js and 1 other location - About 2 hrs to fix
          legacy/src/vms/payment-vm.js on lines 386..392

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 94.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (document.length > 14) {
            isValid = h.validateCnpj(document);
            errorMessage = 'CNPJ inválido.';
        } else {
            isValid = h.validateCpf(striped);
          Severity: Major
          Found in legacy/src/vms/payment-vm.js and 1 other location - About 1 hr to fix
          legacy/src/c/payment-credit-card.js on lines 92..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          window.pagarme.client.connect({ encryption_key: encryptionKey })
                    .then(client => client.security.encrypt(card))
                    .then((cardHash) => {
                        const data = {
                            card_hash: cardHash,
          Severity: Minor
          Found in legacy/src/vms/payment-vm.js and 1 other location - About 50 mins to fix
          legacy/src/vms/common-payment-vm.js on lines 213..281

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status