Sign upLogin

catarse/catarse_moip

View on GitHub
Star

Showing 12 of 16 total issues

Method get_token has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_token(invoice)
    doc = XML::Document.new
    doc.root = XML::Node.new('EnviarInstrucao')    

    unica = XML::Node.new('InstrucaoUnica')
Severity: Major
Found in lib/moip_transparente/checkout.rb - About 5 hrs to fix

    Method process_moip_message has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_moip_message
      payment.with_lock do
        payment_notification = payment.payment_notifications.create({
          contribution: payment.contribution,
          extra_data: JSON.parse(
    Severity: Minor
    Found in app/controllers/catarse_moip/notifications_controller.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateCnpj has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      validateCnpj: function(cnpj) {
    var numeros, digitos, soma, i, resultado, pos, tamanho, digitos_iguais;
    digitos_iguais = 1;
    if (cnpj.length < 14 && cnpj.length < 15)
      return false;
    Severity: Minor
    Found in app/assets/javascripts/catarse_moip/user_document.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onUserDocumentKeyup has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      onUserDocumentKeyup: function(e){
    var $documentField = $(e.currentTarget);

    var documentNumber = $documentField.val();
    $documentField.prop('maxlength', 18);
    Severity: Minor
    Found in app/assets/javascripts/catarse_moip/user_document.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateCnpj has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      validateCnpj: function(cnpj) {
    var numeros, digitos, soma, i, resultado, pos, tamanho, digitos_iguais;
    digitos_iguais = 1;
    if (cnpj.length < 14 && cnpj.length < 15)
      return false;
    Severity: Minor
    Found in app/assets/javascripts/catarse_moip/user_document.js - About 1 hr to fix

      Method get_moip_token has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def get_moip_token
      @contribution = PaymentEngines.find_payment id: params[:id], user_id: current_user.id

      ::MoipTransparente::Config.test = (PaymentEngines.configuration[:moip_test] == 'true')
      ::MoipTransparente::Config.access_token = PaymentEngines.configuration[:moip_token]
      Severity: Minor
      Found in app/controllers/catarse_moip/moip_controller.rb - About 1 hr to fix

        Method first_update_contribution has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def first_update_contribution
      response = ::MoIP.query(contribution.payment_token)
      if response && response["Autorizacao"]
        params = response["Autorizacao"]["Pagamento"]
        params = params.first unless params.respond_to?(:key)
        Severity: Minor
        Found in app/controllers/catarse_moip/moip_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_token has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_token(invoice)
    doc = XML::Document.new
    doc.root = XML::Node.new('EnviarInstrucao')    

    unica = XML::Node.new('InstrucaoUnica')
        Severity: Minor
        Found in lib/moip_transparente/checkout.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method process_moip_message has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def process_moip_message
      payment.with_lock do
        payment_notification = payment.payment_notifications.create({
          contribution: payment.contribution,
          extra_data: JSON.parse(
        Severity: Minor
        Found in app/controllers/catarse_moip/notifications_controller.rb - About 1 hr to fix

          Function onUserDocumentKeyup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            onUserDocumentKeyup: function(e){
    var $documentField = $(e.currentTarget);

    var documentNumber = $documentField.val();
    $documentField.prop('maxlength', 18);
          Severity: Minor
          Found in app/assets/javascripts/catarse_moip/user_document.js - About 1 hr to fix

            Function onSubmit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              onSubmit: function(e) {
    var that = this;
    e.preventDefault();

    if(!that.moipForm.validate()){
            Severity: Minor
            Found in app/assets/javascripts/catarse_moip/payment_card.js - About 1 hr to fix

              Avoid too many return statements within this function.
              Open

                        return false;
              Severity: Major
              Found in app/assets/javascripts/catarse_moip/user_document.js - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language