cattr-app/server-application

View on GitHub
resources/frontend/core/modules/Users/sections/users.js

Summary

Maintainability
F
3 days
Test Coverage

File users.js has 478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import cloneDeep from 'lodash/cloneDeep';
import TimezonePicker from '@/components/TimezonePicker';
import CoreUsersService from '@/services/resource/user.service';
import RoleSelect from '@/components/RoleSelect';
import Users from '../views/Users';
Severity: Minor
Found in resources/frontend/core/modules/Users/sections/users.js - About 7 hrs to fix

    Function fieldsToFillProvider has 184 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function fieldsToFillProvider() {
        return [
            {
                key: 'id',
                displayable: () => false,
    Severity: Major
    Found in resources/frontend/core/modules/Users/sections/users.js - About 7 hrs to fix

      Function fieldsToFillProvider has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export function fieldsToFillProvider() {
          return [
              {
                  key: 'id',
                  displayable: () => false,
      Severity: Minor
      Found in resources/frontend/core/modules/Users/sections/users.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  key: 'type',
                  label: 'field.type',
                  placeholder: 'field.types.any',
                  saveToQuery: true,
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 2 hrs to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 330..352

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  key: 'active',
                  label: 'field.statuses',
                  placeholder: 'users.statuses.any',
                  saveToQuery: true,
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 2 hrs to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 380..402

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  label: 'field.active',
                  key: 'active',
                  render: (h, { currentValue }) => {
                      return h('span', currentValue ? i18n.t('control.yes') : i18n.t('control.no'));
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 1 hr to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 252..258

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  label: 'field.screenshots_active',
                  key: 'screenshots_active',
                  render: (h, { currentValue }) => {
                      return h('span', currentValue ? i18n.t('control.yes') : i18n.t('control.no'));
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 1 hr to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 245..251

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  label: 'field.screenshots_interval',
                  key: 'screenshots_interval',
                  render: (h, { currentValue }) => {
                      return h('span', i18n.t('field.minutes', { value: currentValue }));
      Severity: Minor
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 55 mins to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 282..288

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              {
                  label: 'field.computer_time_popup',
                  key: 'computer_time_popup',
                  render: (h, { currentValue }) => {
                      return h('span', i18n.t('field.minutes', { value: currentValue }));
      Severity: Minor
      Found in resources/frontend/core/modules/Users/sections/users.js and 1 other location - About 55 mins to fix
      resources/frontend/core/modules/Users/sections/users.js on lines 275..281

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                      return h(LanguageSelector, {
                          props: {
                              value: props.currentValue,
                          },
                          on: {
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 4 other locations - About 45 mins to fix
      resources/frontend/core/modules/Invitations/sections/invitations.js on lines 18..27
      resources/frontend/core/modules/Users/sections/account.js on lines 50..59
      resources/frontend/core/modules/Users/sections/users.js on lines 147..156
      resources/frontend/core/modules/Users/sections/users.js on lines 169..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                      return h(RoleSelect, {
                          props: {
                              value: props.currentValue,
                          },
                          on: {
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 4 other locations - About 45 mins to fix
      resources/frontend/core/modules/Invitations/sections/invitations.js on lines 18..27
      resources/frontend/core/modules/Users/sections/account.js on lines 50..59
      resources/frontend/core/modules/Users/sections/users.js on lines 108..117
      resources/frontend/core/modules/Users/sections/users.js on lines 147..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                      return h(TimezonePicker, {
                          props: {
                              value: props.currentValue,
                          },
                          on: {
      Severity: Major
      Found in resources/frontend/core/modules/Users/sections/users.js and 4 other locations - About 45 mins to fix
      resources/frontend/core/modules/Invitations/sections/invitations.js on lines 18..27
      resources/frontend/core/modules/Users/sections/account.js on lines 50..59
      resources/frontend/core/modules/Users/sections/users.js on lines 108..117
      resources/frontend/core/modules/Users/sections/users.js on lines 169..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status