Sign upLogin

cedric/custom_counter_cache

View on GitHub
Star

Showing 4 of 4 total issues

Method update_counter_cache has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    def update_counter_cache(association, cache_column, options = {})
      return unless table_exists?

      association  = association.to_sym
      cache_column = cache_column.to_sym
Severity: Minor
Found in lib/custom_counter_cache/model.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method define_counter_cache has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    def define_counter_cache(cache_column, &block)
      return unless table_exists?

      # counter accessors
      unless column_names.include?(cache_column.to_s)
Severity: Minor
Found in lib/custom_counter_cache/model.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_counter_cache has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def update_counter_cache(association, cache_column, options = {})
      return unless table_exists?

      association  = association.to_sym
      cache_column = cache_column.to_sym
Severity: Minor
Found in lib/custom_counter_cache/model.rb - About 1 hr to fix

    Method define_counter_cache has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def define_counter_cache(cache_column, &block)
      return unless table_exists?

      # counter accessors
      unless column_names.include?(cache_column.to_s)
    Severity: Minor
    Found in lib/custom_counter_cache/model.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language