cerniglj1/osrs-quest-tool

View on GitHub

Showing 82 of 336 total issues

Avoid deeply nested control flow statements.
Open

                    for reco1 in reco_slots:
                        recommended_list.append(reco1)
                else:
Severity: Major
Found in tools/getQuestData.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

              if (cur.boostable) {
                // check if max stew can reach
                if (
                  this.osrsAccount.main.skills[cur.skill] +
                    highestBoost(cur.skill) <
    Severity: Major
    Found in lib/model/quest/QuestTool.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if (
                  account.main.skills[cur.skill] + highestBoost(cur.skill) <
                  cur.level
                ) {
                  return false;
      Severity: Major
      Found in lib/osrstools.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for any_requirement in req_items:
                                skills_needed.append("any: "+any_requirement)
        
        
        Severity: Major
        Found in tools/getQuestData.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                  if (cur.boostable) {
                    // check if max stew can reach
                    if (
                      account.main.skills[cur.skill] + highestBoost(cur.skill) <
                      cur.level
          Severity: Major
          Found in lib/osrstools.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      if (account.main.skills[cur.skill] < cur.level) {
                        return false;
                      }
            Severity: Major
            Found in lib/osrstools.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for any_requirement in req_items:
                                      reqs.append("any: "+any_requirement)
                              elif levelOrQuest.text is not None and 'quest points' in levelOrQuest.text.lower():
              Severity: Major
              Found in tools/getQuestData.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        if (cur.boostable) {
                          // check if max stew can reach
                          if (
                            account.main.skills[cur.skill] + highestBoost(cur.skill) <
                            cur.level
                Severity: Major
                Found in lib/osrstools.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if (
                              account.main.skills[cur.skill] + highestBoost(cur.skill) <
                              cur.level
                            ) {
                              return false;
                  Severity: Major
                  Found in lib/osrstools.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                            if (account.main.combatLevel < cur.level) {
                              return false;
                            }
                    Severity: Major
                    Found in lib/osrstools.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                  if (
                                    this.osrsAccount.main.skills[cur.skill] +
                                      highestBoost(cur.skill) <
                                    cur.level
                                  ) {
                      Severity: Major
                      Found in lib/model/quest/QuestTool.js - About 45 mins to fix

                        Function setCombatLevel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                          setCombatLevel() {
                            var attklvl = this.osrsAccount.main.skills.attack.level
                              ? this.osrsAccount.main.skills.attack.level
                              : 1;
                            var strlvl = this.osrsAccount.main.skills.strength.level
                        Severity: Minor
                        Found in lib/model/account/OsrsAccount.js - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this function.
                        Open

                                  return false;
                        Severity: Major
                        Found in lib/osrstools.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                    return false;
                          Severity: Major
                          Found in lib/osrstools.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return false;
                            Severity: Major
                            Found in lib/osrstools.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                return true;
                              Severity: Major
                              Found in lib/osrstools.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return false;
                                Severity: Major
                                Found in lib/osrstools.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                              return false;
                                  Severity: Major
                                  Found in lib/osrstools.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                            return false;
                                    Severity: Major
                                    Found in lib/osrstools.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                    return false;
                                      Severity: Major
                                      Found in lib/model/quest/QuestTool.js - About 30 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language