Sign upLogin

cerniglj1/osrs-quest-tool

View on GitHub
Star

Showing 254 of 336 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    requirements: {
      quests: ['Priest in Peril', 'The Restless Ghost'],
      skills: [
        {
          skill: 'crafting',
Severity: Major
Found in lib/resources/quest/questData.js and 2 other locations - About 55 mins to fix
lib/resources/quest/questData.js on lines 1134..1148
lib/resources/quest/questData.js on lines 1609..1623

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    requirements: {
      quests: ['The Giant Dwarf', 'Fishing Contest'],
      skills: [
        {
          skill: 'cooking',
Severity: Major
Found in lib/resources/quest/questData.js and 2 other locations - About 55 mins to fix
lib/resources/quest/questData.js on lines 652..666
lib/resources/quest/questData.js on lines 1134..1148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var magiclvl = this.osrsAccount.main.skills.magic.level
      ? this.osrsAccount.main.skills.magic.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 89..91
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var deflvl = this.osrsAccount.main.skills.defence.level
      ? this.osrsAccount.main.skills.defence.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 89..91
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var attklvl = this.osrsAccount.main.skills.attack.level
      ? this.osrsAccount.main.skills.attack.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 89..91
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var rangedlvl = this.osrsAccount.main.skills.ranged.level
      ? this.osrsAccount.main.skills.ranged.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 89..91
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    requirements: {
      quests: ['Underground Pass'],
      skills: [
        {
          skill: 'agility',
Severity: Major
Found in lib/resources/quest/questData.js and 2 other locations - About 55 mins to fix
lib/resources/quest/questData.js on lines 779..793
lib/resources/quest/questData.js on lines 4102..4116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var strlvl = this.osrsAccount.main.skills.strength.level
      ? this.osrsAccount.main.skills.strength.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 89..91
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    requirements: {
      quests: ['Client of Kourend'],
      skills: [
        {
          skill: 'strength',
Severity: Major
Found in lib/resources/quest/questData.js and 2 other locations - About 55 mins to fix
lib/resources/quest/questData.js on lines 779..793
lib/resources/quest/questData.js on lines 3423..3437

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var praylvl = this.osrsAccount.main.skills.prayer.level
      ? this.osrsAccount.main.skills.prayer.level
      : 1;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    requirements: {
      quests: ['The Lost Tribe'],
      skills: [
        {
          skill: 'agility',
Severity: Major
Found in lib/resources/quest/questData.js and 2 other locations - About 55 mins to fix
lib/resources/quest/questData.js on lines 3423..3437
lib/resources/quest/questData.js on lines 4102..4116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    var hplvl = this.osrsAccount.main.skills.hitpoints.level
      ? this.osrsAccount.main.skills.hitpoints.level
      : 10;
Severity: Major
Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
lib/model/account/OsrsAccount.js on lines 74..76
lib/model/account/OsrsAccount.js on lines 77..79
lib/model/account/OsrsAccount.js on lines 80..82
lib/model/account/OsrsAccount.js on lines 83..85
lib/model/account/OsrsAccount.js on lines 86..88
lib/model/account/OsrsAccount.js on lines 89..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

module.exports = exports = {
  SlayerData,
  konar,
  vannaka,
  nieve,
Severity: Minor
Found in src/resources/slayer/slayerData.js and 1 other location - About 50 mins to fix
lib/resources/slayer/slayerData.js on lines 4451..4459

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

module.exports = exports = {
  SlayerData,
  konar,
  vannaka,
  nieve,
Severity: Minor
Found in lib/resources/slayer/slayerData.js and 1 other location - About 50 mins to fix
src/resources/slayer/slayerData.js on lines 4451..4459

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                elif len(levelOrQuest.text.split('\n')) > 0:
                    req_items = levelOrQuest.text.split('\n')
                    for any_requirement in req_items:
                        reqs.append("any: "+any_requirement)
Severity: Major
Found in tools/getQuestData.py and 2 other locations - About 45 mins to fix
tools/getQuestData.py on lines 93..96
tools/getQuestData.py on lines 98..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if levelOrQuest.text is not None and isSkillInString(levelOrQuest.text):
                    req_items = levelOrQuest.text.split('\n')
                    for any_requirement in req_items:
                        skills_needed.append("any: "+any_requirement)
Severity: Major
Found in tools/getQuestData.py and 2 other locations - About 45 mins to fix
tools/getQuestData.py on lines 98..101
tools/getQuestData.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                elif 'not boostable' in levelOrQuest.text or 'boostable' in levelOrQuest.text:
                    req_items = levelOrQuest.text.split('\n')
                    for any_requirement in req_items:
                        skills_needed.append("any: "+any_requirement)
Severity: Major
Found in tools/getQuestData.py and 2 other locations - About 45 mins to fix
tools/getQuestData.py on lines 93..96
tools/getQuestData.py on lines 103..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

                if cols[2] is not None:
                    new_quest['quest_length'] = cols[2]
Severity: Major
Found in tools/getQuestData.py and 11 other locations - About 35 mins to fix
tools/getQuestData.py on lines 193..194
tools/getQuestData.py on lines 195..196
tools/getQuestData.py on lines 201..202
tools/getQuestData.py on lines 204..205
tools/getQuestData.py on lines 208..209
tools/getQuestData.py on lines 210..211
tools/getQuestData.py on lines 213..214
tools/getQuestData.py on lines 216..217
tools/getQuestData.py on lines 219..220
tools/getQuestData.py on lines 222..223
tools/getQuestData.py on lines 225..226

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

                if cols[2] is not None:
                    new_quest['difficulty'] = cols[2]
Severity: Major
Found in tools/getQuestData.py and 11 other locations - About 35 mins to fix
tools/getQuestData.py on lines 193..194
tools/getQuestData.py on lines 195..196
tools/getQuestData.py on lines 198..199
tools/getQuestData.py on lines 201..202
tools/getQuestData.py on lines 204..205
tools/getQuestData.py on lines 208..209
tools/getQuestData.py on lines 210..211
tools/getQuestData.py on lines 216..217
tools/getQuestData.py on lines 219..220
tools/getQuestData.py on lines 222..223
tools/getQuestData.py on lines 225..226

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

                if cols[3] is not None:
                    new_quest['series'] = cols[3]
Severity: Major
Found in tools/getQuestData.py and 11 other locations - About 35 mins to fix
tools/getQuestData.py on lines 193..194
tools/getQuestData.py on lines 195..196
tools/getQuestData.py on lines 198..199
tools/getQuestData.py on lines 204..205
tools/getQuestData.py on lines 208..209
tools/getQuestData.py on lines 210..211
tools/getQuestData.py on lines 213..214
tools/getQuestData.py on lines 216..217
tools/getQuestData.py on lines 219..220
tools/getQuestData.py on lines 222..223
tools/getQuestData.py on lines 225..226

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language