cerniglj1/osrs-quest-tool

View on GitHub
lib/model/account/OsrsAccount.js

Summary

Maintainability
C
1 day
Test Coverage

Function setCombatLevel has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  setCombatLevel() {
    var attklvl = this.osrsAccount.main.skills.attack.level
      ? this.osrsAccount.main.skills.attack.level
      : 1;
    var strlvl = this.osrsAccount.main.skills.strength.level
Severity: Minor
Found in lib/model/account/OsrsAccount.js - About 1 hr to fix

    Function setCombatLevel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      setCombatLevel() {
        var attklvl = this.osrsAccount.main.skills.attack.level
          ? this.osrsAccount.main.skills.attack.level
          : 1;
        var strlvl = this.osrsAccount.main.skills.strength.level
    Severity: Minor
    Found in lib/model/account/OsrsAccount.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var magiclvl = this.osrsAccount.main.skills.magic.level
          ? this.osrsAccount.main.skills.magic.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 89..91
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var hplvl = this.osrsAccount.main.skills.hitpoints.level
          ? this.osrsAccount.main.skills.hitpoints.level
          : 10;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 89..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var rangedlvl = this.osrsAccount.main.skills.ranged.level
          ? this.osrsAccount.main.skills.ranged.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 89..91
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var deflvl = this.osrsAccount.main.skills.defence.level
          ? this.osrsAccount.main.skills.defence.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 89..91
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var praylvl = this.osrsAccount.main.skills.prayer.level
          ? this.osrsAccount.main.skills.prayer.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var attklvl = this.osrsAccount.main.skills.attack.level
          ? this.osrsAccount.main.skills.attack.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 77..79
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 89..91
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        var strlvl = this.osrsAccount.main.skills.strength.level
          ? this.osrsAccount.main.skills.strength.level
          : 1;
    Severity: Major
    Found in lib/model/account/OsrsAccount.js and 6 other locations - About 55 mins to fix
    lib/model/account/OsrsAccount.js on lines 74..76
    lib/model/account/OsrsAccount.js on lines 80..82
    lib/model/account/OsrsAccount.js on lines 83..85
    lib/model/account/OsrsAccount.js on lines 86..88
    lib/model/account/OsrsAccount.js on lines 89..91
    lib/model/account/OsrsAccount.js on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status