Sign upLogin

cerniglj1/osrs-quest-tool

View on GitHub
Star
lib/model/quest/QuestTool.js

Summary

Maintainability
F
4 days
Test Coverage

Function canCompleteQuest has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

  canCompleteQuest(quest) {
    if (quest == undefined || quest == null) {
      return true;
    }
Severity: Minor
Found in lib/model/quest/QuestTool.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function canCompleteQuest has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  canCompleteQuest(quest) {
    if (quest == undefined || quest == null) {
      return true;
    }
Severity: Major
Found in lib/model/quest/QuestTool.js - About 3 hrs to fix

    Function highestBoost has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      highestBoost(skillName) {
    /**
     *
     */
    switch (skillName) {
    Severity: Minor
    Found in lib/model/quest/QuestTool.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  if (this.osrsAccount.main.skills[cur.skill] < cur.level) {
              return false;
            }
      Severity: Major
      Found in lib/model/quest/QuestTool.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (this.osrsAccount.main.combatLevel < cur.level) {
            return false;
          }
        Severity: Major
        Found in lib/model/quest/QuestTool.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    if (cur.boostable) {
            // check if max stew can reach
            if (
              this.osrsAccount.main.skills[cur.skill] +
                highestBoost(cur.skill) <
          Severity: Major
          Found in lib/model/quest/QuestTool.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (
              this.osrsAccount.main.skills[cur.skill] +
                highestBoost(cur.skill) <
              cur.level
            ) {
            Severity: Major
            Found in lib/model/quest/QuestTool.js - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                            return false;
              Severity: Major
              Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return false;
                Severity: Major
                Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return false;
                  Severity: Major
                  Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                  return false;
                    Severity: Major
                    Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                    return false;
                      Severity: Major
                      Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return false;
                        Severity: Major
                        Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                    return false;
                          Severity: Major
                          Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                          return false;
                            Severity: Major
                            Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                  return true;
                              Severity: Major
                              Found in lib/model/quest/QuestTool.js - About 30 mins to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (quest.requirements.quests && quest.requirements.quests >= 1) {
      for (var y in quest.requirements.quests) {
        // If any of the quests required are not completeable: return false
        if (
          canCompleteQuest(this.questObject[quest.requirements.quests[y]]) !=
                                Severity: Major
                                Found in lib/model/quest/QuestTool.js and 1 other location - About 3 hrs to fix
                                lib/osrstools.js on lines 295..304

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 98.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  getQuestByName(questName) {
    if (
      questName &&
      questName != null &&
      questName != undefined &&
                                Severity: Major
                                Found in lib/model/quest/QuestTool.js and 1 other location - About 3 hrs to fix
                                lib/model/quest/QuestTool.js on lines 33..49

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 97.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                  getQuest(questName) {
    if (
      questName &&
      questName != null &&
      questName != undefined &&
                                Severity: Major
                                Found in lib/model/quest/QuestTool.js and 1 other location - About 3 hrs to fix
                                lib/model/quest/QuestTool.js on lines 56..72

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 97.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    if (quest.name === 'Recipe for Disaster') {
      // @todo
      // Pirate Pete Subquest of Recipe for Disaster
      return true;
    } else if (quest.name === 'Pirate Pete subquest of Recipe for Disaster') {
                                Severity: Minor
                                Found in lib/model/quest/QuestTool.js and 1 other location - About 30 mins to fix
                                lib/osrstools.js on lines 222..230

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 45.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status