Sign upLogin

cerniglj1/osrs-quest-tool

View on GitHub
Star
lib/osrstools.js

Summary

Maintainability
F
1 wk
Test Coverage

Function canCompleteQuest has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
Open

function canCompleteQuest(quest, account) {
  if (quest.name === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
Severity: Minor
Found in lib/osrstools.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function meetQuestRequirements has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

function meetQuestRequirements(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
Severity: Minor
Found in lib/osrstools.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function meetsRequirement has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

function meetsRequirement(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
Severity: Minor
Found in lib/osrstools.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function canCompleteQuest has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function canCompleteQuest(quest, account) {
  if (quest.name === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
Severity: Major
Found in lib/osrstools.js - About 2 hrs to fix

    File osrstools.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // import { QuestTool } from './questTool.js';
import { QuestTool } from './classes/Quest/model/QuestTool';
import { SlayerTool } from './classes/Slayer/model/SlayerTool';
import { OsrsAccount } from '../src/lib/model/runescape/OsrsAccount';
    Severity: Minor
    Found in lib/osrstools.js - About 2 hrs to fix

      Function meetQuestRequirements has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function meetQuestRequirements(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
      Severity: Major
      Found in lib/osrstools.js - About 2 hrs to fix

        Function meetsRequirement has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function meetsRequirement(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
        Severity: Major
        Found in lib/osrstools.js - About 2 hrs to fix

          Function highestBoost has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function highestBoost(skillName) {
  /**
   * List of highest boostable levels with skills including spicy stew etc
   */
  switch (skillName) {
          Severity: Minor
          Found in lib/osrstools.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                      if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
          ) {
            return false;
            Severity: Major
            Found in lib/osrstools.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if (account.main.skills[cur.skill] < cur.level) {
            return false;
          }
              Severity: Major
              Found in lib/osrstools.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        if (cur.boostable) {
          // check if max stew can reach
          if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
                Severity: Major
                Found in lib/osrstools.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                          if (account.main.combatLevel < cur.level) {
          return false;
        }
                  Severity: Major
                  Found in lib/osrstools.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                              if (account.main.skills[cur.skill] < cur.level) {
            return false;
          }
                    Severity: Major
                    Found in lib/osrstools.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                              if (account.main.combatLevel < cur.level) {
          return false;
        }
                      Severity: Major
                      Found in lib/osrstools.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                  if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
          ) {
            return false;
                        Severity: Major
                        Found in lib/osrstools.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                  if (cur.boostable) {
          // check if max stew can reach
          if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
                          Severity: Major
                          Found in lib/osrstools.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                      if (account.main.skills[cur.skill] < cur.level) {
            return false;
          }
                            Severity: Major
                            Found in lib/osrstools.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                      if (cur.boostable) {
          // check if max stew can reach
          if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
                              Severity: Major
                              Found in lib/osrstools.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                          if (
            account.main.skills[cur.skill] + highestBoost(cur.skill) <
            cur.level
          ) {
            return false;
                                Severity: Major
                                Found in lib/osrstools.js - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                          if (account.main.combatLevel < cur.level) {
          return false;
        }
                                  Severity: Major
                                  Found in lib/osrstools.js - About 45 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                              return false;
                                    Severity: Major
                                    Found in lib/osrstools.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                return false;
                                      Severity: Major
                                      Found in lib/osrstools.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                    return false;
                                        Severity: Major
                                        Found in lib/osrstools.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                            return true;
                                          Severity: Major
                                          Found in lib/osrstools.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                    return false;
                                            Severity: Major
                                            Found in lib/osrstools.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                          return false;
                                              Severity: Major
                                              Found in lib/osrstools.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                        return false;
                                                Severity: Major
                                                Found in lib/osrstools.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                          return false;
                                                  Severity: Major
                                                  Found in lib/osrstools.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                              return false;
                                                    Severity: Major
                                                    Found in lib/osrstools.js - About 30 mins to fix

                                                      Avoid too many return statements within this function.
                                                      Open

                                                              return false;
                                                      Severity: Major
                                                      Found in lib/osrstools.js - About 30 mins to fix

                                                        Avoid too many return statements within this function.
                                                        Open

                                                                  return false;
                                                        Severity: Major
                                                        Found in lib/osrstools.js - About 30 mins to fix

                                                          Avoid too many return statements within this function.
                                                          Open

                                                                      return false;
                                                          Severity: Major
                                                          Found in lib/osrstools.js - About 30 mins to fix

                                                            Avoid too many return statements within this function.
                                                            Open

                                                                      return false;
                                                            Severity: Major
                                                            Found in lib/osrstools.js - About 30 mins to fix

                                                              Avoid too many return statements within this function.
                                                              Open

                                                                          return false;
                                                              Severity: Major
                                                              Found in lib/osrstools.js - About 30 mins to fix

                                                                Avoid too many return statements within this function.
                                                                Open

                                                                          return false;
                                                                Severity: Major
                                                                Found in lib/osrstools.js - About 30 mins to fix

                                                                  Avoid too many return statements within this function.
                                                                  Open

                                                                              return false;
                                                                  Severity: Major
                                                                  Found in lib/osrstools.js - About 30 mins to fix

                                                                    Avoid too many return statements within this function.
                                                                    Open

                                                                                return false;
                                                                    Severity: Major
                                                                    Found in lib/osrstools.js - About 30 mins to fix

                                                                      Avoid too many return statements within this function.
                                                                      Open

                                                                        return true;
                                                                      Severity: Major
                                                                      Found in lib/osrstools.js - About 30 mins to fix

                                                                        Avoid too many return statements within this function.
                                                                        Open

                                                                          return true;
                                                                        Severity: Major
                                                                        Found in lib/osrstools.js - About 30 mins to fix

                                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                          function meetQuestRequirements(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
                                                                          Severity: Major
                                                                          Found in lib/osrstools.js and 1 other location - About 3 days to fix
                                                                          lib/osrstools.js on lines 324..413

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 517.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                          function meetsRequirement(quest, account) {
  if (quest === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
                                                                          Severity: Major
                                                                          Found in lib/osrstools.js and 1 other location - About 3 days to fix
                                                                          lib/osrstools.js on lines 121..210

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 517.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          Identical blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                            if (quest.requirements.quests && quest.requirements.quests >= 1) {
    for (var y in quest.requirements.quests) {
      // If any of the quests required are not completeable: return false
      if (
        canCompleteQuest(this.questObject[quest.requirements.quests[y]]) != true
                                                                          Severity: Major
                                                                          Found in lib/osrstools.js and 1 other location - About 3 hrs to fix
                                                                          lib/model/quest/QuestTool.js on lines 249..259

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 98.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                            if (quest.name === 'Recipe for Disaster') {
    // TODO
    // Pirate Pete Subquest of Recipe for Disaster
    return true;
  } else if (quest.name === 'Pirate Pete subquest of Recipe for Disaster') {
                                                                          Severity: Minor
                                                                          Found in lib/osrstools.js and 1 other location - About 30 mins to fix
                                                                          lib/model/quest/QuestTool.js on lines 174..182

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 45.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          There are no issues that match your filters.

                                                                          Category
                                                                          Status