cfillion/middle_squid

View on GitHub

Showing 3 of 3 total issues

Method append_to has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def append_to(category, line)
      # fix invalid UTF-8 byte sequences
      line.scrub! ''

      # remove trailing whitespace
Severity: Minor
Found in lib/middle_squid/indexer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def index_file(path)
      pn = Pathname.new path
      return unless pn.file?

      dirname = pn.dirname.basename.to_s
Severity: Minor
Found in lib/middle_squid/indexer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method download_like has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def download_like(request, uri)
    fiber = Fiber.current

    method = request.request_method.downcase.to_sym

Severity: Minor
Found in lib/middle_squid/helpers.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language