Sign upLogin

cfpb/owning-a-home

View on GitHub
Star
src/static/js/modules/loan-comparison/stores/loan-store.js

Summary

Maintainability
D
2 days
Test Coverage

File loan-store.js has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var $ = require( 'jquery' );
var assign = require( 'object-assign' );
Severity: Minor
Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 4 hrs to fix

    LoanStore has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    var LoanStore = assign( {}, EventEmitter.prototype, {

  _loans: [],

  downpaymentConstant: 'downpayment-percent',
    Severity: Minor
    Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 4 hrs to fix

      Function jumboCheck has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        jumboCheck: function( loan ) {
    var newType;
    var loanType = loan['loan-type'];

    // make sure we have a previous type
      Severity: Minor
      Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function dispatchToken has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      LoanStore.dispatchToken = AppDispatcher.register( function( action ) {
  switch( action.actionType ) {

    case LoanConstants.UPDATE_LOAN:
      // update both loans or single loan, dep. on whether the prop changed
      Severity: Minor
      Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 1 hr to fix

        Function dispatchToken has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        LoanStore.dispatchToken = AppDispatcher.register( function( action ) {
  switch( action.actionType ) {

    case LoanConstants.UPDATE_LOAN:
      // update both loans or single loan, dep. on whether the prop changed
        Severity: Minor
        Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function jumboCheck has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          jumboCheck: function( loan ) {
    var newType;
    var loanType = loan['loan-type'];

    // make sure we have a previous type
        Severity: Minor
        Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 1 hr to fix

          Function processRatesData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            processRatesData: function( data ) {
    // data: [rate: frequency, rate: frequency,...]
    data = data || {};
    var rates = [];
    var totalRates = [];
          Severity: Minor
          Found in src/static/js/modules/loan-comparison/stores/loan-store.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            fetchRates: function( loan ) {
    return api.fetchRateData( loan )
              .done( function( results ) {
                LoanStore.updateLoanRates( loan, ( results || {} ).data );
              } );
          Severity: Major
          Found in src/static/js/modules/loan-comparison/stores/loan-store.js and 1 other location - About 1 hr to fix
          src/static/js/modules/loan-comparison/stores/loan-store.js on lines 282..287

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            fetchInsurance: function( loan ) {
    return api.fetchMortgageInsuranceData( loan )
              .done( function( results ) {
                LoanStore.updateLoanInsurance( loan, ( results || {} ).data );
              } );
          Severity: Major
          Found in src/static/js/modules/loan-comparison/stores/loan-store.js and 1 other location - About 1 hr to fix
          src/static/js/modules/loan-comparison/stores/loan-store.js on lines 306..311

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status