Plugin: Refactor BBB to use new conference tables - refs #6153 #6161
christianbeeznest wants to merge
christianbeeznest:GH-6153 into chamilo:masterFailed
16 issues to fix.
Showing 23 of 23 total issues
Avoid deeply nested control flow statements. New
New
switch ($action) { case 'FAILED': $bbb->endMeeting($value['id'], $courseCode); break; case 'SUCCESS':Avoid deeply nested control flow statements. New
New
switch ($status) { case 'FAILED': $bbb->endMeeting($meetingId, $courseCode); break; case 'SUCCESS':Function getMeetingsLight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. New
New
public function getMeetingsLight( $courseId = 0, $sessionId = 0, $groupId = 0, $dateRange = []- Read upRead up
Method getMeetingParticipantInfo has 28 lines of code (exceeds 25 allowed). Consider refactoring. New
New
public function getMeetingParticipantInfo($meetingId, $userId): array { $em = Database::getManager(); /** @var ConferenceActivityRepository $repo */ $repo = $em->getRepository(ConferenceActivity::class);Method getAllMeetingsInCourse has 31 lines of code (exceeds 25 allowed). Consider refactoring. New
New
public function getAllMeetingsInCourse($courseId, $sessionId, $status) { $em = Database::getManager(); $courseEntity = api_get_course_entity($courseId); $sessionEntity = api_get_session_entity($sessionId);Method getMeetingsLight has 31 lines of code (exceeds 25 allowed). Consider refactoring. New
New
public function getMeetingsLight( $courseId = 0, $sessionId = 0, $groupId = 0, $dateRange = []Method findConnectedMeetingParticipants has 26 lines of code (exceeds 25 allowed). Consider refactoring. New
New
public function findConnectedMeetingParticipants(int $meetingId): array { $em = Database::getManager(); /** @var ConferenceActivityRepository $repo */ $repo = $em->getRepository(ConferenceActivity::class);Method findOneArrayByMeetingAndParticipant has 27 lines of code (exceeds 25 allowed). Consider refactoring. New
New
public function findOneArrayByMeetingAndParticipant(int $meetingId, int $participantId): ?array { $qb = $this->createQueryBuilder('a') ->where('a.meeting = :meetingId') ->andWhere('a.participant = :participantId')Identical blocks of code found in 2 locations. Consider refactoring. New
New
return [ 'id' => $meeting->getId(), 'c_id' => $meeting->getCourse()?->getId(), 'session_id' => $meeting->getSession()?->getId(), 'meeting_name' => $meeting->getTitle(),- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 910..928
Identical blocks of code found in 2 locations. Consider refactoring. New
New
$results[] = [ 'id' => $meeting->getId(), 'c_id' => $meeting->getCourse()?->getId(), 'session_id' => $meeting->getSession()?->getId(), 'meeting_name' => $meeting->getTitle(),- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 867..885
Similar blocks of code found in 2 locations. Consider refactoring. New
New
return [ 'id' => $activity->getId(), 'meeting_id' => $activity->getMeeting()?->getId(), 'participant_id' => $activity->getParticipant()?->getId(), 'in_at' => $activity->getInAt()?->format('Y-m-d H:i:s'),- Read upRead up
src/CoreBundle/Repository/ConferenceActivityRepository.php on lines 67..79
Similar blocks of code found in 2 locations. Consider refactoring. New
New
return [ 'id' => $entity->getId(), 'meeting_id' => $entity->getMeeting()?->getId(), 'participant_id' => $entity->getParticipant()?->getId(), 'in_at' => $entity->getInAt()?->format('Y-m-d H:i:s'),- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 740..752
Similar blocks of code found in 2 locations. Consider refactoring. New
New
if (!empty($dateRange)) { $dateStart = (new \DateTime($dateRange['search_meeting_start']))->setTime(0, 0, 0); $dateEnd = (new \DateTime($dateRange['search_meeting_end']))->setTime(23, 59, 59); $meetings = $repo->findByDateRange($dateStart, $dateEnd); } elseif ($this->isGlobalConference()) {- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 1092..1106
Similar blocks of code found in 2 locations. Consider refactoring. New
New
if (!empty($dateRange)) { $dateStart = (new \DateTime($dateRange['search_meeting_start']))->setTime(0, 0, 0); $dateEnd = (new \DateTime($dateRange['search_meeting_end']))->setTime(23, 59, 59); $meetings = $repo->findByDateRange($dateStart, $dateEnd); } else {- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 960..987
Similar blocks of code found in 2 locations. Consider refactoring. New
New
public function publishMeeting($id) { if (empty($id)) { return false; }- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 1489..1508
Similar blocks of code found in 2 locations. Consider refactoring. New
New
public function unpublishMeeting($id) { if (empty($id)) { return false; }- Read upRead up
public/plugin/bbb/lib/bbb.lib.php on lines 1465..1484
Avoid deeply nested control flow statements. Fixed
Avoid deeply nested control flow statements. Fixed
File bbb_plugin.class.php has 269 lines of code (exceeds 250 allowed). Consider refactoring. Fixed
Function uninstall has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Fixed
- Read upRead up
Method install has 74 lines of code (exceeds 25 allowed). Consider refactoring. Fixed
Method uninstall has 55 lines of code (exceeds 25 allowed). Consider refactoring. Fixed
Function endMeeting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Fixed
- Read upRead up