Sign upLogin

chamilo/chamilo-lms

View on GitHub
Star

Catalogue: Add "Catalogue access" tab to restrict visibility by usergroup - refs #6163
#6204

christianbeeznest wants to merge christianbeeznest:GH-6163 into chamilo:master
Compare on GitHub
Failed
3 issues to fix.

Showing 3 of 3 total issues

File session_edit.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
New

<?php
 
/* For licensing terms, see /license.txt */
 
use Chamilo\CoreBundle\Entity\CatalogueSessionRelAccessUrlRelUsergroup;
Severity: Minor
Found in public/main/session/session_edit.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    New

        if ($formCatalogue->validate()) {
            $data = $formCatalogue->getSubmitValues();
            $newGroups = $data['selected_usergroups'] ?? [];
     
            foreach ($existing as $old) {
    Severity: Major
    Found in public/main/session/session_edit.php and 1 other location - About 5 hrs to fix
    public/main/admin/course_edit.php on lines 612..637

    Similar blocks of code found in 2 locations. Consider refactoring.
    New

        if ($formCatalogue->validate()) {
            $data = $formCatalogue->getSubmitValues();
            $newGroups = $data['selected_usergroups'] ?? [];
     
            foreach ($existing as $old) {
    Severity: Major
    Found in public/main/admin/course_edit.php and 1 other location - About 5 hrs to fix
    public/main/session/session_edit.php on lines 119..144
    Category
    Status
    FileMaintainability
    public/main/admin/course_edit.php
    B
    D
    +1 day
    public/main/session/session_edit.php
    A
    C
    +1 day