changeweb/Unifiedtransform

View on GitHub

Showing 27 of 50 total issues

Method run has 125 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        // Reset cached roles and permissions
        app()[PermissionRegistrar::class]->forgetCachedPermissions();

Severity: Major
Found in database/seeders/PermissionSeeder.php - About 5 hrs to fix

    File settings.blade.php has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    @extends('layouts.app')
    
    @section('content')
    <script src="{{ asset('js/masonry.pkgd.min.js') }}"></script>
    <div class="container">
    Severity: Minor
    Found in resources/views/academics/settings.blade.php - About 2 hrs to fix

      Method up has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function up()
          {
              $tableNames = config('permission.table_names');
              $columnNames = config('permission.column_names');
      
      
      Severity: Major
      Found in database/migrations/2021_08_14_063609_create_permission_tables.php - About 2 hrs to fix

        Method createStudent has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function createStudent($request) {
                try {
                    DB::transaction(function () use ($request) {
                        $student = User::create([
                            'first_name'    => $request['first_name'],
        Severity: Minor
        Found in app/Repositories/UserRepository.php - About 1 hr to fix

          Method createTeacher has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function createTeacher($request) {
                  try {
                      DB::transaction(function () use ($request) {
                          $user = User::create([
                              'first_name'    => $request['first_name'],
          Severity: Minor
          Found in app/Repositories/UserRepository.php - About 1 hr to fix

            Method index has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function index(Request $request)
                {
                    $class_id = $request->query('class_id', 0);
                    $section_id = $request->query('section_id', 0);
                    $course_id = $request->query('course_id', 0);
            Severity: Minor
            Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

              Method showCourseMark has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function showCourseMark(Request $request)
                  {
                      $session_id = $request->query('session_id');
                      $semester_id = $request->query('semester_id');
                      $class_id = $request->query('class_id');
              Severity: Minor
              Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

                Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function create(Request $request)
                    {
                        $class_id = $request->query('class_id');
                        $section_id = $request->query('section_id');
                        $course_id = $request->query('course_id');
                Severity: Minor
                Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

                  Method create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function create(Request $request)
                      {
                          if($request->query('class_id') == null){
                              return abort(404);
                          }
                  Severity: Minor
                  Found in app/Http/Controllers/AttendanceController.php - About 1 hr to fix

                    Function index has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function index(Request $request)
                        {
                            $class_id = $request->query('class_id', 0);
                            $section_id = $request->query('section_id', 0);
                            $course_id = $request->query('course_id', 0);
                    Severity: Minor
                    Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function showCourseMark has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function showCourseMark(Request $request)
                        {
                            $session_id = $request->query('session_id');
                            $semester_id = $request->query('semester_id');
                            $class_id = $request->query('class_id');
                    Severity: Minor
                    Found in app/Http/Controllers/MarkController.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method rules has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function rules()
                        {
                            return [
                                'first_name'        => 'required|string',
                                'last_name'         => 'required|string',
                    Severity: Minor
                    Found in app/Http/Requests/StudentStoreRequest.php - About 1 hr to fix

                      Method calendarEvents has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function calendarEvents(Request $request)
                          {
                              $current_school_session_id = $this->getSchoolCurrentSession();
                              $event = null;
                              switch ($request->type) {
                      Severity: Minor
                      Found in app/Http/Controllers/EventController.php - About 1 hr to fix

                        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                AcademicSettingInterface $academicSettingRepository,
                                SchoolSessionInterface $schoolSessionRepository,
                                SchoolClassInterface $schoolClassRepository,
                                SectionInterface $schoolSectionRepository,
                                UserInterface $userRepository,
                        Severity: Major
                        Found in app/Http/Controllers/AcademicSettingController.php - About 50 mins to fix

                          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  AcademicSettingInterface $academicSettingRepository,
                                  UserInterface $userRepository,
                                  SchoolSessionInterface $schoolSessionRepository,
                                  SchoolClassInterface $schoolClassRepository,
                                  SectionInterface $schoolSectionRepository,
                          Severity: Major
                          Found in app/Http/Controllers/MarkController.php - About 50 mins to fix

                            Method getAllByStudentId has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function getAllByStudentId($session_id, $semester_id, $class_id, $section_id, $course_id, $student_id) {
                            Severity: Minor
                            Found in app/Repositories/MarkRepository.php - About 45 mins to fix

                              Method getAllFinalMarksByStudentId has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function getAllFinalMarksByStudentId($session_id, $student_id, $semester_id, $class_id, $section_id, $course_id);
                              Severity: Minor
                              Found in app/Interfaces/MarkInterface.php - About 45 mins to fix

                                Method getAllByStudentId has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public function getAllByStudentId($session_id, $semester_id, $class_id, $section_id, $course_id, $student_id);
                                Severity: Minor
                                Found in app/Interfaces/MarkInterface.php - About 45 mins to fix

                                  Method getAllFinalMarksByStudentId has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public function getAllFinalMarksByStudentId($session_id, $student_id, $semester_id, $class_id, $section_id, $course_id) {
                                  Severity: Minor
                                  Found in app/Repositories/MarkRepository.php - About 45 mins to fix

                                    Method getFinalMarksCount has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        public function getFinalMarksCount($session_id, $semester_id, $class_id, $section_id, $course_id) {
                                    Severity: Minor
                                    Found in app/Repositories/MarkRepository.php - About 35 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language