Sign upLogin

changeweb/Unifiedtransform

View on GitHub
Star

Showing 27 of 50 total issues

Method getAllFinalMarks has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getAllFinalMarks($session_id, $semester_id, $class_id, $section_id, $course_id) {
Severity: Minor
Found in app/Repositories/MarkRepository.php - About 35 mins to fix

    Method getAssignedTeacher has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function getAssignedTeacher($session_id, $semester_id, $class_id, $section_id, $course_id) {
    Severity: Minor
    Found in app/Repositories/AssignedTeacherRepository.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              UserInterface $userRepository,
        AcademicSettingInterface $academicSettingRepository,
        SchoolSessionInterface $schoolSessionRepository,
        SchoolClassInterface $schoolClassRepository,
        SectionInterface $sectionRepository
      Severity: Minor
      Found in app/Http/Controllers/AttendanceController.php - About 35 mins to fix

        Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getAll($session_id, $semester_id, $class_id, $section_id, $course_id) {
        Severity: Minor
        Found in app/Repositories/MarkRepository.php - About 35 mins to fix

          Method getAssignedTeacher has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function getAssignedTeacher($session_id, $semester_id, $class_id, $section_id, $course_id);
          Severity: Minor
          Found in app/Interfaces/AssignedTeacherInterface.php - About 35 mins to fix

            Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function getAll($session_id, $semester_id, $class_id, $section_id, $course_id);
            Severity: Minor
            Found in app/Interfaces/MarkInterface.php - About 35 mins to fix

              Function getAllStudents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getAllStudents($session_id, $class_id, $section_id) {
        if($class_id == 0 || $section_id == 0) {
            $schoolClass = SchoolClass::where('session_id', $session_id)
                                    ->first();
            $section = Section::where('session_id', $session_id)
              Severity: Minor
              Found in app/Repositories/UserRepository.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language