Sign upLogin

chartjs/Chart.js

View on GitHub
Star
src/core/core.controller.js

Summary

Maintainability
F
4 days
Test Coverage

File core.controller.js has 878 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import animator from './core.animator.js';
import defaults, {overrides} from './core.defaults.js';
import Interaction from './core.interaction.js';
import layouts from './core.layouts.js';
import {_detectPlatform} from '../platform/index.js';
Severity: Major
Found in src/core/core.controller.js - About 2 days to fix

    Chart has 64 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Chart {

  static defaults = defaults;
  static instances = instances;
  static overrides = overrides;
    Severity: Major
    Found in src/core/core.controller.js - About 1 day to fix

      Function buildOrUpdateScales has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        buildOrUpdateScales() {
    const options = this.options;
    const scaleOpts = options.scales;
    const scales = this.scales;
    const updated = Object.keys(scales).reduce((obj, id) => {
      Severity: Major
      Found in src/core/core.controller.js - About 2 hrs to fix

        Function constructor has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(item, userConfig) {
    const config = this.config = new Config(userConfig);
    const initialCanvas = getCanvas(item);
    const existingChart = getChart(initialCanvas);
    if (existingChart) {
        Severity: Major
        Found in src/core/core.controller.js - About 2 hrs to fix

          Function bindResponsiveEvents has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            bindResponsiveEvents() {
    if (!this._responsiveListeners) {
      this._responsiveListeners = {};
    }
    const listeners = this._responsiveListeners;
          Severity: Minor
          Found in src/core/core.controller.js - About 1 hr to fix

            Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              update(mode) {
    const config = this.config;

    config.update();
    const options = this._options = config.createResolver(config.chartOptionScopes(), this.getContext());
            Severity: Minor
            Found in src/core/core.controller.js - About 1 hr to fix

              Function buildOrUpdateControllers has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                buildOrUpdateControllers() {
    const newControllers = [];
    const datasets = this.data.datasets;
    let i, ilen;
              Severity: Minor
              Found in src/core/core.controller.js - About 1 hr to fix

                Function _drawDataset has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  _drawDataset(meta) {
    const ctx = this.ctx;
    const clip = meta._clip;
    const useClip = !clip.disabled;
    const area = getDatasetArea(meta, this.chartArea);
                Severity: Minor
                Found in src/core/core.controller.js - About 1 hr to fix

                  Function _drawDataset has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
                  Open

                    _drawDataset(meta) {
    const ctx = this.ctx;
    const clip = meta._clip;
    const useClip = !clip.disabled;
    const area = getDatasetArea(meta, this.chartArea);
                  Severity: Minor
                  Found in src/core/core.controller.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function buildOrUpdateControllers has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
                  Open

                    buildOrUpdateControllers() {
    const newControllers = [];
    const datasets = this.data.datasets;
    let i, ilen;
                  Severity: Minor
                  Found in src/core/core.controller.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Invalid

                      return a[l1] === b[l1]
      ? a[l2] - b[l2]
      : a[l1] - b[l1];
                  Severity: Minor
                  Found in src/core/core.controller.js and 1 other location - About 30 mins to fix
                  src/core/core.layouts.js on lines 22..24

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status