Sign upLogin

chiefy/vaulted

View on GitHub
Star
lib/backends/secret.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Vaulted.write = Promise.method(function writeSecret(options, mountName) {
  options = options || {};

  return this.getSecretEndpoint(mountName)
    .put({
Severity: Major
Found in lib/backends/secret.js and 3 other locations - About 3 hrs to fix
lib/auth/appid.js on lines 59..69
lib/auth/appid.js on lines 127..137
lib/auth/token.js on lines 77..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

Vaulted.read = Promise.method(function readSecret(options, mountName) {
  options = options || {};

  return this.getSecretEndpoint(mountName)
    .get({
Severity: Major
Found in lib/backends/secret.js and 16 other locations - About 2 hrs to fix
lib/auth/appid.js on lines 35..44
lib/auth/appid.js on lines 82..91
lib/auth/appid.js on lines 104..113
lib/auth/appid.js on lines 150..159
lib/auth/token.js on lines 54..63
lib/auth/token.js on lines 100..109
lib/auth/token.js on lines 122..131
lib/auth/token.js on lines 144..153
lib/auth/token.js on lines 166..175
lib/auth/token.js on lines 188..197
lib/backends/consul.js on lines 38..46
lib/backends/consul.js on lines 96..104
lib/backends/consul.js on lines 117..125
lib/backends/transit.js on lines 81..90
lib/backends/transit.js on lines 105..114
lib/backends/transit.js on lines 158..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

Vaulted.delete = Promise.method(function deleteSecret(options, mountName) {
  options = options || {};

  return this.getSecretEndpoint(mountName)
    .delete({
Severity: Major
Found in lib/backends/secret.js and 2 other locations - About 2 hrs to fix
lib/auth/appid.js on lines 173..183
lib/backends/consul.js on lines 138..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status