Sign upLogin

chippyash/Math-Type-Calculator

View on GitHub
Star

Showing 14 of 38 total issues

Native has 40 functions (exceeds 20 allowed). Consider refactoring.
Open

class Native implements CalculatorEngineInterface
{
    use NativeConvertNumeric;
    use CheckRationalTypes;
    use CheckIntTypes;
Severity: Minor
Found in src/Chippyash/Math/Type/Calculator/Native.php - About 5 hrs to fix

    File Native.php has 354 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Arithmetic calculation support for Chippyash Strong Types
 *
 * @author    Ashley Kitson <akitson@zf4.biz>
    Severity: Minor
    Found in src/Chippyash/Math/Type/Calculator/Native.php - About 4 hrs to fix

      Function arbitrate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function arbitrate(NumericTypeInterface $a, NumericTypeInterface $b)
    {
        $pairing = $this->getTypePairing($a, $b);
        if ($pairing == 'complex:complex') {
            return 'complex';
      Severity: Minor
      Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return $this->calcEngine->complexMul($a->asComplex(), $b);
      Severity: Major
      Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->calcEngine->complexMul($a, $b);
        Severity: Major
        Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return 'float';
          Severity: Major
          Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $this->calcEngine->rationalAdd($a, $b);
            Severity: Major
            Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->calcEngine->rationalMul($a, $b);
              Severity: Major
              Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this->complexCompare($a->asComplex(), $b);
                Severity: Major
                Found in src/Chippyash/Math/Type/Comparator/Native.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $this->calcEngine->complexAdd($a->asComplex(), $b);
                  Severity: Major
                  Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->calcEngine->complexSub($a, $b);
                    Severity: Major
                    Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $this->calcEngine->complexDiv($a->asComplex(), $b);
                      Severity: Major
                      Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return 'whole';
                        Severity: Major
                        Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return $this->calcEngine->complexAdd($a, $b);
                          Severity: Major
                          Found in src/Chippyash/Math/Type/Calculator.php - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language