Sign upLogin

chris-garrett/feathers-redux-immutablejs

View on GitHub
Star

Showing 12 of 12 total issues

Function reduxifyService has 241 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reduxifyService = (app, route, name = route, options = {}) => {
  const debug = makeDebug(`reducer:${name}`);
  debug(`route ${route}`);

  const defaults = {
Severity: Major
Found in src/index.js - About 1 day to fix

    Function reduxifyService has 213 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const reduxifyService = (app, route, name = route, options = {}) => {
  const debug = makeDebug(`reducer:${name}`);
  debug(`route ${route}`);

  const defaults = {
    Severity: Major
    Found in src/immutablejs.js - About 1 day to fix

      Function reduxifyService has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      const reduxifyService = (app, route, name = route, options = {}) => {
  const debug = makeDebug(`reducer:${name}`);
  debug(`route ${route}`);

  const defaults = {
      Severity: Minor
      Found in src/index.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File index.js has 319 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { createAction, handleActions } from 'redux-actions';
import { bindActionCreators } from 'redux';
import makeDebug from 'debug';

/**
      Severity: Minor
      Found in src/index.js - About 3 hrs to fix

        File immutablejs.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        
import Immutable from 'immutable';
import { createAction, handleActions } from 'redux-actions';
import { bindActionCreators } from 'redux';
import makeDebug from 'debug';
        Severity: Minor
        Found in src/immutablejs.js - About 3 hrs to fix

          Function reduxifyService has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

          const reduxifyService = (app, route, name = route, options = {}) => {
  const debug = makeDebug(`reducer:${name}`);
  debug(`route ${route}`);

  const defaults = {
          Severity: Minor
          Found in src/immutablejs.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function render has 68 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
    const { getServicesStatus, reduxState: { messages: messagesState } } = this.props;
    
    return (
      <div className="App">
          Severity: Major
          Found in example/client/App.js - About 2 hrs to fix

            Function reducerForServiceMethod has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              const reducerForServiceMethod = (actionType, ifLoading, isFind) => {
    const slicedActionType = actionType.slice(SERVICE_NAME.length, actionType.length).toLowerCase(); // returns find/create/update/patch (etc.)
    const pendingResults = getPendingDefaults(slicedActionType);

    return {
            Severity: Minor
            Found in src/index.js - About 1 hr to fix

              Function reducerForServiceMethod has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                const reducerForServiceMethod = (actionType, ifLoading, isFind) => {
    const slicedActionType = actionType.slice(SERVICE_NAME.length, actionType.length).toLowerCase(); // returns find/create/update/patch (etc.)
    const pendingResults = getPendingDefaults(slicedActionType);

    return {
              Severity: Minor
              Found in src/immutablejs.js - About 1 hr to fix

                Function getServicesStatus has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export const getServicesStatus = (servicesState, serviceNames) => {
  const status = {
    message: '',
    className: '',
    serviceName: ''
                Severity: Minor
                Found in src/immutablejs.js - About 1 hr to fix

                  Function getServicesStatus has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export const getServicesStatus = (servicesState, serviceNames) => {
  var status = {
    message: '',
    className: '',
    serviceName: ''
                  Severity: Minor
                  Found in src/index.js - About 1 hr to fix

                    Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    module.exports = function () {
  return function (hook) {
    let message = `${hook.type}: ${hook.path} - Method: ${hook.method}`;

    if (hook.type === 'error') {
                    Severity: Minor
                    Found in example/server/hooks/logger.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language