chrislit/abydos

View on GitHub

Showing 383 of 4,191 total issues

Function sim_score has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def sim_score(self, src: str, tar: str) -> float:
        """Return the Gotoh score of two strings.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_gotoh.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sim has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def sim(self, src: str, tar: str) -> float:
        """Return Cao's CY similarity (CYs) of two strings.

        Parameters
        ----------
Severity: Minor
Found in abydos/distance/_cao.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _phonetic has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _phonetic(
Severity: Major
Found in abydos/phonetic/_beider_morse.py - About 50 mins to fix

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in abydos/distance/_generalized_fleiss.py - About 50 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          for inst in installed:  # pragma: no branch
                              if pack[0] == inst[0] and pack[2] <= inst[2]:
                                  if not silent:
                                      print(  # pragma: no cover  # noqa: T001
                                          '{} package already up-to-date'.format(
      Severity: Major
      Found in abydos/util/_data.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if not search(right, phoneticx[i + pattern_length :]):
                                    continue
        
                            # check that left context is satisfied
                            if lcontext != '':
        Severity: Major
        Found in abydos/phonetic/_beider_morse.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if start2 > 0:
                                          pos = start2
                                          start1 = start2
                                          start2 = -1
                                          end1 = end2
          Severity: Major
          Found in abydos/phonetic/_phonet.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if word[pos + 1 : pos + 2] == 'U':
                                        pos += 2
                                    else:
                                        pos += 1
                                    meta_key += 'K'
            Severity: Major
            Found in abydos/phonetic/_spanish_metaphone.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if not any(
                                          abbr in fname for abbr in ('i.', 'v.', 'x.')
                                      ):
                                          full_name = full_name[:loc]
                                          toolcode[7] += '{:03d}'.format(num) + 'a'
              Severity: Major
              Found in abydos/fingerprint/_synoname_toolcode.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if os.path.isdir(os.path.join(check_path, package)):
                                        with open(
                                            os.path.join(check_path, package + '.xml')
                                        ) as xml:
                                            file = xml.read()
                Severity: Major
                Found in abydos/util/_data.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if not search(left, phoneticx[:i]):
                                              continue
                  
                                      # check for incompatible attributes
                                      candidate = self._apply_rule_if_compat(
                  Severity: Major
                  Found in abydos/phonetic/_beider_morse.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if k > 0:
                                                    # add hash value for this letter
                                                    if phonet_hash_1[j, k] < 0:
                                                        phonet_hash_1[j, k] = i
                                                        phonet_hash_2[j, k] = i
                    Severity: Major
                    Found in abydos/phonetic/_phonet.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if (
                                                      (len(src) > (i + matches))
                                                      and src[i + matches].isalpha()
                                                      and (src[i + matches] in rule[1:])
                                                  ):
                      Severity: Major
                      Found in abydos/phonetic/_phonet.py - About 45 mins to fix

                        Function _expand_alternates has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def _expand_alternates(self, phonetic: str) -> str:
                                r"""Expand phonetic alternates separated by \|s.
                        
                                Parameters
                                ----------
                        Severity: Minor
                        Found in abydos/phonetic/_beider_morse.py - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                if _string_at(
                                                    (current + 3),
                                                    2,
                                                    {'OO', 'ER', 'EN', 'UY', 'ED', 'EM'},
                                                ):
                        Severity: Major
                        Found in abydos/phonetic/_double_metaphone.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if (
                                                      (current == 1) and _get_at(current - 1) == 'A'
                                                  ) or _string_at((current - 1), 5, {'UCCEE', 'UCCES'}):
                                                      primary, secondary = _metaph_add('KS')
                                                  # 'bacci', 'bertucci', other italian
                          Severity: Major
                          Found in abydos/phonetic/_double_metaphone.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if not _is_vowel(pos + 1) and pos == 0:
                                                        meta_key += 'ES'
                                                        pos += 1
                                                    else:
                                                        meta_key += 'S'
                            Severity: Major
                            Found in abydos/phonetic/_spanish_metaphone.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if (
                                                          len(word) > 1
                                                          and pos == 0
                                                          and not _is_vowel(pos + 1)
                                                      ):
                              Severity: Major
                              Found in abydos/phonetic/_spanish_metaphone.py - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                            if pos0 >= 0:
                                                                while (_phonet_rules[pos0] is None) or (
                                                                    cast(str, _phonet_rules[pos0])[0] == char0
                                                                ):
                                                                    if pos0 > end3:
                                Severity: Major
                                Found in abydos/phonetic/_phonet.py - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if current > 0:
                                                              if _string_at(0, 2, {'MC'}):
                                                                  # e.g., "McHugh"
                                                                  primary, secondary = _metaph_add('K')
                                                              else:
                                  Severity: Major
                                  Found in abydos/phonetic/_double_metaphone.py - About 45 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language