Sign upLogin

cityssm/faster-web-helper

View on GitHub
Star

Showing 35 of 47 total issues

Function handler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function handler(request: Request, response: Response): void {
  const user = request.session
    .purchaseOrderApprovalUser as PurchaseOrderApprovalSessionUser

  if (user.approvalMax <= 0) {
Severity: Minor
Found in modules/purchaseOrderApprovals/handlers/post/doCreatePurchaseOrder.ts - About 1 hr to fix

    Function handler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function handler(request, response) {
    const userName = (request.body.userName ?? '').toLowerCase();
    const password = (request.body.password ?? '');
    const isAuthenticated = await authenticate(userName, password);
    let sessionHasUser = false;
    Severity: Minor
    Found in modules/purchaseOrderApprovals/handlers/post/doLogin.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function runActiveEquipmentTask has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function runActiveEquipmentTask() {
    if (assetListConfig === undefined) {
        return;
    }
    debug(`Running "${taskName}"...`);
    Severity: Minor
    Found in modules/worktechUpdate/tasks/activeEquipmentTask.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function handler(
  request: Request,
  response: Response
): Promise<void> {
  const userName = ((request.body.userName ?? '') as string).toLowerCase()
    Severity: Minor
    Found in modules/purchaseOrderApprovals/handlers/post/doLogin.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function runActiveEquipmentTask has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function runActiveEquipmentTask(): Promise<void> {
  if (assetListConfig === undefined) {
    return
  }
    Severity: Minor
    Found in modules/worktechUpdate/tasks/activeEquipmentTask.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function runDirectChargeHelperTask has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function runDirectChargeHelperTask() {
    if (directChargeTransactionsConfig === undefined) {
        return;
    }
    debug(`Running "${taskName}"...`);
    Severity: Minor
    Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if (returnToVendorRecord === undefined) {
                            continue;
                        }
    Severity: Major
    Found in modules/worktechUpdate/tasks/inventoryTransactionsTask.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for (const workOrderResourceToDebit of debitableWorkOrderResources) {
                            if (remainingQuantityToDebit <= 0) {
                                break;
                            }
                            const newResourceItemQuantity = Math.max(workOrderResourceToDebit.quantity - remainingQuantityToDebit, 0);
      Severity: Major
      Found in modules/worktechUpdate/tasks/inventoryTransactionsTask.js - About 45 mins to fix

        Function initializeAutocompleteModule has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function initializeAutocompleteModule(
  options: ModuleInitializerOptions
): Promise<void> {
  debug(`Initializing "${moduleName}"...`)
        Severity: Minor
        Found in modules/autocomplete/initializeAutocompleteModule.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function initializeWorktechUpdateModule has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function initializeWorktechUpdateModule(options) {
    debug(`Initializing "${moduleName}"...`);
    /*
     * Ensure the local database is available.
     */
        Severity: Minor
        Found in modules/worktechUpdate/initializeWorktechUpdateModule.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function initializeWorktechUpdateModule has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function initializeWorktechUpdateModule(options?: ModuleInitializerOptions): Promise<void> {
  debug(`Initializing "${moduleName}"...`)

  /*
   * Ensure the local database is available.
        Severity: Minor
        Found in modules/worktechUpdate/initializeWorktechUpdateModule.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function runUpdateAssetNumbersTask has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function runUpdateAssetNumbersTask() {
    debug(`Running "${taskName}"...`);
    /*
     * Download files to temp
     */
        Severity: Minor
        Found in modules/autocomplete/tasks/updateAssetNumbersTask.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function initializeAutocompleteModule has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function initializeAutocompleteModule(options) {
    debug(`Initializing "${moduleName}"...`);
    /*
     * Set up static server
     */
        Severity: Minor
        Found in modules/autocomplete/initializeAutocompleteModule.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function runUpdateAssetNumbersTask has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function runUpdateAssetNumbersTask(): Promise<void> {
  debug(`Running "${taskName}"...`)

  /*
   * Download files to temp
        Severity: Minor
        Found in modules/autocomplete/tasks/updateAssetNumbersTask.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _trackReturnToVendorRecords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function _trackReturnToVendorRecords(report, data) {
    for (const transaction of data.transactions) {
        if (transaction.repairDescription.startsWith('Return to Vendor - ')) {
            const transactionRecord = {
                documentNumber: data.documentNumber,
        Severity: Minor
        Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language