Sign upLogin

cityssm/faster-web-helper

View on GitHub
Star
modules/worktechUpdate/tasks/directChargeHelperTask.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function _updateWorkOrderNumberMappings has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

async function _updateWorkOrderNumberMappings(report, data) {
    const mapping = getWorkOrderNumberMapping(data.documentNumber);
    const exportDate = dateStringToInteger(report.exportDate);
    const exportTime = timeStringToInteger(report.exportTime);
    if (mapping === undefined) {
Severity: Minor
Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _updateWorkOrderNumberMappings has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function _updateWorkOrderNumberMappings(report, data) {
    const mapping = getWorkOrderNumberMapping(data.documentNumber);
    const exportDate = dateStringToInteger(report.exportDate);
    const exportTime = timeStringToInteger(report.exportTime);
    if (mapping === undefined) {
Severity: Minor
Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 1 hr to fix

    Function runDirectChargeHelperTask has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default async function runDirectChargeHelperTask() {
    if (directChargeTransactionsConfig === undefined) {
        return;
    }
    debug(`Running "${taskName}"...`);
    Severity: Minor
    Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _trackReturnToVendorRecords has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function _trackReturnToVendorRecords(report, data) {
    for (const transaction of data.transactions) {
        if (transaction.repairDescription.startsWith('Return to Vendor - ')) {
            const transactionRecord = {
                documentNumber: data.documentNumber,
    Severity: Minor
    Found in modules/worktechUpdate/tasks/directChargeHelperTask.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status