cityssm/node-docushare

View on GitHub

Showing 5 of 14 total issues

Function findChildren has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

export const findChildren = async (parentCollectionHandleString: string, findChildrenFilters: types.FindChildrenFilters = {}): Promise<types.DocuShareOutput> => {

  const children = await getChildren(parentCollectionHandleString);

  if (!children.success) {
Severity: Minor
Found in index.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findChildren has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

export const findChildren = async (parentCollectionHandleString, findChildrenFilters = {}) => {
    const children = await getChildren(parentCollectionHandleString);
    if (!children.success) {
        return children;
    }
Severity: Minor
Found in index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findChildren has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const findChildren = async (parentCollectionHandleString, findChildrenFilters = {}) => {
    const children = await getChildren(parentCollectionHandleString);
    if (!children.success) {
        return children;
    }
Severity: Minor
Found in index.js - About 1 hr to fix

    Function findChildren has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const findChildren = async (parentCollectionHandleString: string, findChildrenFilters: types.FindChildrenFilters = {}): Promise<types.DocuShareOutput> => {
    
      const children = await getChildren(parentCollectionHandleString);
    
      if (!children.success) {
    Severity: Minor
    Found in index.ts - About 1 hr to fix

      Method dsJQueryToJSONArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

           public static JSONArray dsJQueryToJSONArray (DSJQuery ds) throws DSAuthorizationException, JSONException, DSException {
              
              JSONArray jsonArr = new JSONArray();
              
              for (DSObject dsObj : ds) {
      Severity: Minor
      Found in java/src/cityssm/nodedocusharejava/NodeDocuShareJavaUtils.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language