Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star
src/conversion/downcastdispatcher.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function convertSelection has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    convertSelection( selection, markers, writer ) {
        const markersAtSelection = Array.from( markers.getMarkersAtPosition( selection.getFirstPosition() ) );

        this.conversionApi.writer = writer;
        this.conversionApi.consumable = this._createSelectionConsumable( selection, markersAtSelection );
Severity: Minor
Found in src/conversion/downcastdispatcher.js - About 1 hr to fix

    Function convertSelection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        convertSelection( selection, markers, writer ) {
        const markersAtSelection = Array.from( markers.getMarkersAtPosition( selection.getFirstPosition() ) );

        this.conversionApi.writer = writer;
        this.conversionApi.consumable = this._createSelectionConsumable( selection, markersAtSelection );
    Severity: Minor
    Found in src/conversion/downcastdispatcher.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function convertChanges has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        convertChanges( differ, markers, writer ) {
        // Before the view is updated, remove markers which have changed.
        for ( const change of differ.getMarkersToRemove() ) {
            this.convertMarkerRemove( change.name, change.range, writer );
        }
    Severity: Minor
    Found in src/conversion/downcastdispatcher.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function convertMarkerAdd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        convertMarkerAdd( markerName, markerRange, writer ) {
        // Do not convert if range is in graveyard or not in the document (e.g. in DocumentFragment).
        if ( !markerRange.root.document || markerRange.root.rootName == '$graveyard' ) {
            return;
        }
    Severity: Minor
    Found in src/conversion/downcastdispatcher.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status