Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star
src/conversion/downcasthelpers.js

Summary

Maintainability
D
2 days
Test Coverage

File downcasthelpers.js has 465 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
 * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
 */
Severity: Minor
Found in src/conversion/downcasthelpers.js - About 7 hrs to fix

    Function changeAttribute has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function changeAttribute( attributeCreator ) {
    return ( evt, data, conversionApi ) => {
        const oldAttribute = attributeCreator( data.attributeOldValue, data );
        const newAttribute = attributeCreator( data.attributeNewValue, data );
    Severity: Minor
    Found in src/conversion/downcasthelpers.js - About 1 hr to fix

      Function createViewElementFromDefinition has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      function createViewElementFromDefinition( viewElementDefinition, viewWriter, viewElementType ) {
    if ( typeof viewElementDefinition == 'string' ) {
        // If `viewElementDefinition` is given as a `String`, normalize it to an object with `name` property.
        viewElementDefinition = { name: viewElementDefinition };
    }
      Severity: Minor
      Found in src/conversion/downcasthelpers.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createViewElementFromDefinition has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createViewElementFromDefinition( viewElementDefinition, viewWriter, viewElementType ) {
    if ( typeof viewElementDefinition == 'string' ) {
        // If `viewElementDefinition` is given as a `String`, normalize it to an object with `name` property.
        viewElementDefinition = { name: viewElementDefinition };
    }
      Severity: Minor
      Found in src/conversion/downcasthelpers.js - About 1 hr to fix

        Function highlightText has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function highlightText( highlightDescriptor ) {
    return ( evt, data, conversionApi ) => {
        if ( !data.item ) {
            return;
        }
        Severity: Minor
        Found in src/conversion/downcasthelpers.js - About 1 hr to fix

          Function insertUIElement has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function insertUIElement( elementCreator ) {
    return ( evt, data, conversionApi ) => {
        // Create two view elements. One will be inserted at the beginning of marker, one at the end.
        // If marker is collapsed, only "opening" element will be inserted.
        data.isOpening = true;
          Severity: Minor
          Found in src/conversion/downcasthelpers.js - About 1 hr to fix

            Function normalizeToAttributeConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function normalizeToAttributeConfig( view ) {
    if ( typeof view == 'string' ) {
        return modelAttributeValue => ( { key: view, value: modelAttributeValue } );
    } else if ( typeof view == 'object' ) {
        // { key, value, ... }
            Severity: Minor
            Found in src/conversion/downcasthelpers.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function downcastAttributeToElement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function downcastAttributeToElement( config ) {
    config = cloneDeep( config );

    const modelKey = config.model.key ? config.model.key : config.model;
    let eventName = 'attribute:' + modelKey;
            Severity: Minor
            Found in src/conversion/downcasthelpers.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function downcastAttributeToAttribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function downcastAttributeToAttribute( config ) {
    config = cloneDeep( config );

    const modelKey = config.model.key ? config.model.key : config.model;
    let eventName = 'attribute:' + modelKey;
            Severity: Minor
            Found in src/conversion/downcasthelpers.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ( newAttribute.key == 'class' ) {
                const classes = Array.isArray( newAttribute.value ) ? newAttribute.value : [ newAttribute.value ];

                for ( const className of classes ) {
                    viewWriter.addClass( className, viewElement );
            Severity: Major
            Found in src/conversion/downcasthelpers.js and 1 other location - About 1 hr to fix
            src/conversion/downcasthelpers.js on lines 849..863

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ( oldAttribute.key == 'class' ) {
                const classes = Array.isArray( oldAttribute.value ) ? oldAttribute.value : [ oldAttribute.value ];

                for ( const className of classes ) {
                    viewWriter.removeClass( className, viewElement );
            Severity: Major
            Found in src/conversion/downcasthelpers.js and 1 other location - About 1 hr to fix
            src/conversion/downcasthelpers.js on lines 868..882

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if ( viewElementDefinition.styles ) {
        const keys = Object.keys( viewElementDefinition.styles );

        for ( const key of keys ) {
            viewWriter.setStyle( key, viewElementDefinition.styles[ key ], element );
            Severity: Major
            Found in src/conversion/downcasthelpers.js and 1 other location - About 1 hr to fix
            src/conversion/downcasthelpers.js on lines 874..882

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        } else if ( newAttribute.key == 'style' ) {
                const keys = Object.keys( newAttribute.value );

                for ( const key of keys ) {
                    viewWriter.setStyle( key, newAttribute.value[ key ], viewElement );
            Severity: Major
            Found in src/conversion/downcasthelpers.js and 1 other location - About 1 hr to fix
            src/conversion/downcasthelpers.js on lines 1243..1249

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status