Sign upLogin

ckeditor/ckeditor5-engine

View on GitHub
Star
src/model/treewalker.js

Summary

Maintainability
D
2 days
Test Coverage

Function _previous has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    _previous() {
        const previousPosition = this.position;
        const position = this.position.clone();
        const parent = this._visitedParent;
Severity: Minor
Found in src/model/treewalker.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _next has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    _next() {
        const previousPosition = this.position;
        const position = this.position.clone();
        const parent = this._visitedParent;
Severity: Minor
Found in src/model/treewalker.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _previous has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _previous() {
        const previousPosition = this.position;
        const position = this.position.clone();
        const parent = this._visitedParent;
Severity: Minor
Found in src/model/treewalker.js - About 1 hr to fix

    Function _next has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _next() {
        const previousPosition = this.position;
        const position = this.position.clone();
        const parent = this._visitedParent;
    Severity: Minor
    Found in src/model/treewalker.js - About 1 hr to fix

      Function constructor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          constructor( options = {} ) {
        if ( !options.boundaries && !options.startPosition ) {
            /**
             * Neither boundaries nor starting position of a `TreeWalker` have been defined.
             *
      Severity: Minor
      Found in src/model/treewalker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor( options = {} ) {
        if ( !options.boundaries && !options.startPosition ) {
            /**
             * Neither boundaries nor starting position of a `TreeWalker` have been defined.
             *
      Severity: Minor
      Found in src/model/treewalker.js - About 1 hr to fix

        Function formatReturnValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function formatReturnValue( type, item, previousPosition, nextPosition, length ) {
        Severity: Minor
        Found in src/model/treewalker.js - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

                          return formatReturnValue( 'elementStart', node, previousPosition, position, 1 );
          Severity: Major
          Found in src/model/treewalker.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return formatReturnValue( 'text', item, previousPosition, position, charactersCount );
            Severity: Major
            Found in src/model/treewalker.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return formatReturnValue( 'elementEnd', parent, previousPosition, position );
              Severity: Major
              Found in src/model/treewalker.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return formatReturnValue( 'elementStart', parent, previousPosition, position, 1 );
                Severity: Major
                Found in src/model/treewalker.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return this._next();
                  Severity: Major
                  Found in src/model/treewalker.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if ( this._boundaryEndParent == parent && this.boundaries.end.offset < offset ) {
                    offset = this.boundaries.end.offset;
                }
                    Severity: Minor
                    Found in src/model/treewalker.js and 1 other location - About 55 mins to fix
                    src/model/treewalker.js on lines 343..345

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if ( this._boundaryStartParent == parent && this.boundaries.start.offset > offset ) {
                    offset = this.boundaries.start.offset;
                }
                    Severity: Minor
                    Found in src/model/treewalker.js and 1 other location - About 55 mins to fix
                    src/model/treewalker.js on lines 259..261

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ( parent === this._boundaryEndParent && position.offset == this.boundaries.end.offset ) {
            return { done: true };
        }
                    Severity: Minor
                    Found in src/model/treewalker.js and 1 other location - About 55 mins to fix
                    src/model/treewalker.js on lines 307..309

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ( parent == this._boundaryStartParent && position.offset == this.boundaries.start.offset ) {
            return { done: true };
        }
                    Severity: Minor
                    Found in src/model/treewalker.js and 1 other location - About 55 mins to fix
                    src/model/treewalker.js on lines 229..231

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        next() {
        if ( this.direction == 'forward' ) {
            return this._next();
        } else {
            return this._previous();
                    Severity: Minor
                    Found in src/model/treewalker.js and 1 other location - About 50 mins to fix
                    src/view/treewalker.js on lines 179..185

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status