ckeditor/ckeditor5-engine

View on GitHub
src/view/treewalker.js

Summary

Maintainability
F
4 days
Test Coverage

Function _previous has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    _previous() {
        let position = this.position.clone();
        const previousPosition = this.position;
        const parent = position.parent;

Severity: Minor
Found in src/view/treewalker.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _next has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    _next() {
        let position = this.position.clone();
        const previousPosition = this.position;
        const parent = position.parent;

Severity: Minor
Found in src/view/treewalker.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _previous has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _previous() {
        let position = this.position.clone();
        const previousPosition = this.position;
        const parent = position.parent;

Severity: Major
Found in src/view/treewalker.js - About 2 hrs to fix

    Function _next has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _next() {
            let position = this.position.clone();
            const previousPosition = this.position;
            const parent = position.parent;
    
    
    Severity: Major
    Found in src/view/treewalker.js - About 2 hrs to fix

      Function _formatReturnValue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          _formatReturnValue( type, item, previousPosition, nextPosition, length ) {
              // Text is a specific parent, because contains string instead of children.
              // Walker doesn't enter to the Text except situations when walker is iterating over every single character,
              // or the bound starts/ends inside the Text. So when the position is at the beginning or at the end of the Text
              // we move it just before or just after Text.
      Severity: Minor
      Found in src/view/treewalker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          constructor( options = {} ) {
              if ( !options.boundaries && !options.startPosition ) {
                  /**
                   * Neither boundaries nor starting position have been defined.
                   *
      Severity: Minor
      Found in src/view/treewalker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _formatReturnValue has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _formatReturnValue( type, item, previousPosition, nextPosition, length ) {
              // Text is a specific parent, because contains string instead of children.
              // Walker doesn't enter to the Text except situations when walker is iterating over every single character,
              // or the bound starts/ends inside the Text. So when the position is at the beginning or at the end of the Text
              // we move it just before or just after Text.
      Severity: Minor
      Found in src/view/treewalker.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                        return this._next();
        Severity: Major
        Found in src/view/treewalker.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return this._formatReturnValue( 'text', textProxy, previousPosition, position, textLength );
          Severity: Major
          Found in src/view/treewalker.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return this._formatReturnValue( 'elementStart', node, previousPosition, position, 1 );
            Severity: Major
            Found in src/view/treewalker.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return this._formatReturnValue( 'text', textProxy, previousPosition, position, textLength );
              Severity: Major
              Found in src/view/treewalker.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return this._formatReturnValue( 'elementStart', parent, previousPosition, position, 1 );
                Severity: Major
                Found in src/view/treewalker.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return this._formatReturnValue( 'text', item, previousPosition, position, charactersCount );
                  Severity: Major
                  Found in src/view/treewalker.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return this._formatReturnValue( 'elementEnd', node, previousPosition, position );
                    Severity: Major
                    Found in src/view/treewalker.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return this._previous();
                      Severity: Major
                      Found in src/view/treewalker.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return this._next();
                        Severity: Major
                        Found in src/view/treewalker.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return this._formatReturnValue( 'elementEnd', parent, previousPosition, position );
                          Severity: Major
                          Found in src/view/treewalker.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return this._formatReturnValue( 'text', item, previousPosition, position, charactersCount );
                            Severity: Major
                            Found in src/view/treewalker.js - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          if ( item.offsetInText === 0 ) {
                                              if ( this.direction == 'backward' && !( this.boundaries && this.boundaries.start.isEqual( this.position ) ) ) {
                                                  nextPosition = Position._createBefore( item.textNode );
                                                  // When we change nextPosition of returned value we need also update walker current position.
                                                  this.position = nextPosition;
                              Severity: Major
                              Found in src/view/treewalker.js and 1 other location - About 3 hrs to fix
                              src/view/treewalker.js on lines 422..430

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 110.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          if ( item.offsetInText + item.data.length == item.textNode.data.length ) {
                                              if ( this.direction == 'forward' && !( this.boundaries && this.boundaries.end.isEqual( this.position ) ) ) {
                                                  nextPosition = Position._createAfter( item.textNode );
                                                  // When we change nextPosition of returned value we need also update walker current position.
                                                  this.position = nextPosition;
                              Severity: Major
                              Found in src/view/treewalker.js and 1 other location - About 3 hrs to fix
                              src/view/treewalker.js on lines 433..441

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 110.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( parent == this._boundaryStartParent && position.offset == this.boundaries.start.offset ) {
                                          return { done: true };
                                      }
                              Severity: Minor
                              Found in src/view/treewalker.js and 1 other location - About 50 mins to fix
                              src/view/treewalker.js on lines 206..208

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 52.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( parent === this._boundaryEndParent && position.offset == this.boundaries.end.offset ) {
                                          return { done: true };
                                      }
                              Severity: Minor
                              Found in src/view/treewalker.js and 1 other location - About 50 mins to fix
                              src/view/treewalker.js on lines 312..314

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 52.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  next() {
                                      if ( this.direction == 'forward' ) {
                                          return this._next();
                                      } else {
                                          return this._previous();
                              Severity: Minor
                              Found in src/view/treewalker.js and 1 other location - About 50 mins to fix
                              src/model/treewalker.js on lines 202..208

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 51.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status