Sign upLogin

clairelee/directable

View on GitHub
Star

Showing 5 of 11 total issues

Method create has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def create
        # Create a new profile if a profile matching the name doesn't exist yet
        @note = @user.new_note(note_params)
    
        if @note.save
Severity: Minor
Found in app/controllers/notes_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method path_to has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def path_to(page_name)
    case page_name

    when /^the home\s?page$/
      '/'
Severity: Minor
Found in features/support/paths.rb - About 1 hr to fix

    Method search has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def search
        flash[:search_result_notice] = ""
        filtered_notes = @user.all_notes
        if note_params[:name] != ""
            filtered_notes = filtered_notes.where("lower(name) like ?", "%#{note_params[:name]}%")
    Severity: Minor
    Found in app/controllers/notes_controller.rb - About 1 hr to fix

      Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def create
        # Create a new profile if a profile matching the name doesn't exist yet
        @note = @user.new_note(note_params)
    
        if @note.save
      Severity: Minor
      Found in app/controllers/notes_controller.rb - About 1 hr to fix

        Method search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def search
        flash[:search_result_notice] = ""
        filtered_notes = @user.all_notes
        if note_params[:name] != ""
            filtered_notes = filtered_notes.where("lower(name) like ?", "%#{note_params[:name]}%")
        Severity: Minor
        Found in app/controllers/notes_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language