Sign upLogin

clearsightstudio/ProMotion-form

View on GitHub
Star

Showing 3 of 3 total issues

Method form_data has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def form_data
    [{
      title: "Account Information",
      footer: "Some help text",
      cells: [{
Severity: Major
Found in app/test_screens/test_form_screen.rb - About 2 hrs to fix

    Method input_data has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def input_data(input)
      data = {}

      # check for ProMotion helpers
      if input[:image]
    Severity: Minor
    Found in lib/ProMotion/form/form.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_style has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.to_style(obj, out={}, ary=[])
      obj.each do |key, val|
        case val
        when Hash  then next to_style(val, out, ary + [key.to_s])
        when Class then val = val.new
    Severity: Minor
    Found in lib/ProMotion/form/form_style.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language