Showing 79 of 89 total issues
Method download!
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
def download!(&blk)
destination_file.binmode
sha1 = Digest::SHA1.new
http = EM::HttpRequest.new(source_uri, :inactivity_timeout => 30).get
Method instances_filtered_by_message
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def instances_filtered_by_message(message)
app_id = message.data["droplet"].to_s
logger.debug2("Filter message for app_id: %s" % app_id, app_id: app_id)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method start
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def start
staging_promise = Promise.new do |p|
resolve_staging_setup
resolve_staging
p.deliver
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method download!
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def download!(&blk)
destination_file.binmode
sha1 = Digest::SHA1.new
http = EM::HttpRequest.new(source_uri, :inactivity_timeout => 30).get
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method promise_save_buildpack_cache
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def promise_save_buildpack_cache
Promise.new do |p|
resolve_and_log(promise_pack_buildpack_cache, 'staging.buildpack-cache.save') do |error, _|
unless error
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method start
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def start(&callback)
p = Promise.new do
logger.info('droplet.starting')
promise_state(State::BORN, State::STARTING).resolve
Method resolve_staging_setup
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def resolve_staging_setup
workspace.prepare(buildpack_manager)
with_network = false
stack = staging_message.stack
Method generate
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.generate(bootstrap, instance, request)
response = {
"dea" => bootstrap.uuid,
"droplet" => instance.application_id,
"version" => instance.application_version,
Method handle_dea_stop
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def handle_dea_stop(message)
if message.data.size == 1 && message.data['droplet']
staging_stop_msg = Dea::Nats::Message.new(
message.nats,
'staging.stop',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method start
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def start
staging_promise = Promise.new do |p|
resolve_staging_setup
resolve_staging
p.deliver
Method load
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def load
return unless File.exist?(path)
start = Time.now
Method upload!
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def upload!(&upload_callback)
logger.info("em-upload.begin", destination: URICleaner.clean(@destination))
SyncUpload.new(@source, @destination, @logger).upload! do |http, error|
if error
Method download_one_buildpack
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def download_one_buildpack(buildpack, dest_dir)
Dea::Promise.new do |p|
tmpfile = Tempfile.new('temp_admin_buildpack')
Download.new(buildpack.fetch(:url), tmpfile, nil, logger).download! do |err|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method snapshot_attributes
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def snapshot_attributes
{
'cc_partition' => attributes['cc_partition'],
'instance_id' => attributes['instance_id'],
Method rule_args_for_protocol
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def rule_args_for_protocol(protocol, rule)
base_args = {
handle: container_handle,
protocol: protocol,
network: rule['destination'],
Method promise_stage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def promise_stage
Promise.new do |p|
script = staging_command
logger.debug('staging.task.execute-staging')
Method initialize
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(uuid, local_ip, message_bus, locator_responders, instance_registry, evac_handler, shutdown_handler, logger)
Method download
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def download(uri, &blk)
if exists?
blk.call(nil)
return
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method promise_stop
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def promise_stop(kill_flag = false)
Promise.new do |p|
begin
if container.handle
request = ::Warden::Protocol::StopRequest.new(handle: container.handle, kill: kill_flag)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method emit_metrics
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def emit_metrics(now)
return unless @container.handle
info = @container.info
rescue => e
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"