cloudmatrix/esky

View on GitHub

Showing 175 of 271 total issues

Avoid too many return statements within this function.
Open

    return True
Severity: Major
Found in esky/winres.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return True
    Severity: Major
    Found in esky/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return True
      Severity: Major
      Found in esky/__init__.py - About 30 mins to fix

        Function load_resource_pystr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def load_resource_pystr(py,filename,resname,resid,reslang):
            """Load the named resource from the given file as a python-level string
        
            The filename and resource name must be ascii strings, and the resid and
            reslang must be integers.
        Severity: Minor
        Found in esky/bdist_esky/pypy_winres.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function load_filelist has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def load_filelist(root):
            '''locates the esky file list, reads it and returns it as a sorted list'''
            for path, dirs, files in os.walk(root):
                for f in files:
                    if f == ESKY_FILELIST:
        Severity: Minor
        Found in esky/patch.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _check_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _check_path(self,path):
                if self.root is not None:
                    path = os.path.normpath(os.path.join(self.root,path))
                    if len(self.root) == 2:
                        prefix = self.root
        Severity: Minor
        Found in esky/fstransact/win32txf.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function load_resource has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def load_resource(filename,resname,resid,reslang):
            """Load the named resource from the given file.
        
            The filename and resource name must be ascii strings, and the resid and
            reslang must be integers.
        Severity: Minor
        Found in esky/bdist_esky/pypy_winres.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function patch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def patch(self):
                """Interpret and apply patch commands to the target.
        
                This is a simple command loop that dispatches to the _do_<CMD>
                methods defined below.  It keeps processing until one of them
        Severity: Minor
        Found in esky/patch.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _make_py2app_cmd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def _make_py2app_cmd(dist_dir,distribution,options,exes):
            exe = exes[0]
            extra_exes = exes[1:]
            cmd = py2app(distribution)
            for (nm,val) in options.iteritems():
        Severity: Minor
        Found in esky/bdist_esky/f_py2app.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_bootstrap_code has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get_bootstrap_code(self):
                """Get any extra code to be executed by the bootstrapping exe.
        
                This method interprets the bootstrap-code and bootstrap-module settings
                to construct any extra bootstrapping code that must be executed by
        Severity: Minor
        Found in esky/bdist_esky/__init__.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _check_end_patch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _check_end_patch(self):
                """Finish patching the current file, if there is one.
        
                This method is called by all non-file-patching commands; if there is
                a file open for patching then it is closed and committed.
        Severity: Minor
        Found in esky/patch.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _check_root has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _check_root(self):
                if self.root is not None:
                    #  Verify that files under the given root can actually be
                    #  operated on transactionally.  We do this by trying to move
                    #  the root directory to itself.  This should always fail, but
        Severity: Minor
        Found in esky/fstransact/win32txf.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _get_versions_dir has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _get_versions_dir(self):
                """Get the directory path containing individual version dirs."""
                if not ESKY_APPDATA_DIR:
                    return self.appdir
                # TODO: remove compatability hooks for ESKY_APPDATA_DIR=""
        Severity: Minor
        Found in esky/__init__.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _version_manifest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _version_manifest(self, vdir):
                """Get the bootstrap manifest for the given version directory.
        
                This is the set of files/directories that the given version expects
                to be in the main app directory.
        Severity: Minor
        Found in esky/__init__.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_loaded_modules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_loaded_modules():
            """Iterator over the currently-loaded modules of the current process.
        
            This is a skinny little wrapper around the EnumProcessModules and 
            GetModuleFileName functions.
        Severity: Minor
        Found in esky/winres.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language