Sign upLogin

cmattoon/aws-ssm

View on GitHub
Star

Showing 7 of 7 total issues

Method Controller.WatchSecrets has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Controller) WatchSecrets(cli kubernetes.Interface) error {
    for {
        select {
        case <-c.Context.Done():
            log.Info("context finished processing")
Severity: Minor
Found in pkg/controller/controller.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Controller.WatchSecrets has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Controller) WatchSecrets(cli kubernetes.Interface) error {
    for {
        select {
        case <-c.Context.Done():
            log.Info("context finished processing")
Severity: Minor
Found in pkg/controller/controller.go - About 1 hr to fix

    Function NewSecret has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func NewSecret(ctx context.Context, sec v1.Secret, p provider.Provider, secret_name string, secret_namespace string, param_name string, param_type string, param_key string, roleArn string) (*Secret, error) {
    Severity: Major
    Found in pkg/secret/secret.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if err != nil {
                        log.Warnf("Watcher failed to update object %s/%s", obj.Namespace, obj.Name)
                        log.Warn(err.Error())
                        continue
                    }
      Severity: Major
      Found in pkg/controller/controller.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if nilCounter > maxNils {
                        break
                    }
        Severity: Major
        Found in pkg/controller/controller.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if err != nil {
                        // Error: Irrelevant Secret
                        continue
                    }
          Severity: Major
          Found in pkg/controller/controller.go - About 45 mins to fix

            Function NewSecret has 5 return statements (exceeds 4 allowed).
            Open

            func NewSecret(ctx context.Context, sec v1.Secret, p provider.Provider, secret_name string, secret_namespace string, param_name string, param_type string, param_key string, roleArn string) (*Secret, error) {

    s := &Secret{
        Secret:     sec,
        Name:       secret_name,
            Severity: Major
            Found in pkg/secret/secret.go - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language