Sign upLogin

cmspsgp31/anubis

View on GitHub
Star
anubis/frontend/src/app.js

Summary

Maintainability
F
3 days
Test Coverage

File app.js has 461 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright © 2016, Ugo Pozo
//             2016, Câmara Municipal de São Paulo

// app.js - main component of the search interface.
Severity: Minor
Found in anubis/frontend/src/app.js - About 7 hrs to fix

    Function renderAction has 118 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        renderAction() {
        const open = !!this.props.currentAction;

        let actionData = I.fromJS({});
    Severity: Major
    Found in anubis/frontend/src/app.js - About 4 hrs to fix

      Function renderError has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          renderError() {
        let error = this.props.globalError;

        const showErrorDialog = !!error && this.props.showErrorDetails;
        const showErrorSnackbar = !!error && !this.props.showErrorDetails;
      Severity: Major
      Found in anubis/frontend/src/app.js - About 2 hrs to fix

        Function renderUserInfo has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            renderUserInfo() {
        let userShow;

        const firstName = this.props.user.get('first_name', "");
        Severity: Major
        Found in anubis/frontend/src/app.js - About 2 hrs to fix

          Function render has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              render() {
        let navHeader;

        if (I.is(this.props.user, I.Map())) {
            navHeader = this.renderLogin();
          Severity: Major
          Found in anubis/frontend/src/app.js - About 2 hrs to fix

            Function renderAction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                renderAction() {
        const open = !!this.props.currentAction;

        let actionData = I.fromJS({});
            Severity: Minor
            Found in anubis/frontend/src/app.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                get searchApi() {
        /*eslint-disable no-unused-vars */
        const model = this.props.params.model;
        const expr = this.props.params.splat;
        const page = this.props.params.page;
            Severity: Major
            Found in anubis/frontend/src/app.js and 2 other locations - About 3 hrs to fix
            anubis/frontend/src/components/record_list.js on lines 179..188
            anubis/frontend/src/components/record_zoom.js on lines 142..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 113.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    sidebarLinks: IPropTypes.contains({
            admin: RPropTypes.string,
            list: IPropTypes.list,
            login: RPropTypes.string,
            logout: RPropTypes.string,
            Severity: Major
            Found in anubis/frontend/src/app.js and 2 other locations - About 1 hr to fix
            anubis/frontend/src/app.js on lines 88..94
            anubis/frontend/src/components/record_zoom.js on lines 75..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    user: IPropTypes.contains({
            email: RPropTypes.string,
            first_name: RPropTypes.string,
            last_name: RPropTypes.string,
            profile_link: RPropTypes.string,
            Severity: Major
            Found in anubis/frontend/src/app.js and 2 other locations - About 1 hr to fix
            anubis/frontend/src/app.js on lines 81..87
            anubis/frontend/src/components/record_zoom.js on lines 75..81

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status