cmspsgp31/anubis

View on GitHub
anubis/frontend/src/components/TokenField/token_list.js

Summary

Maintainability
D
1 day
Test Coverage

File token_list.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright © 2016, Ugo Pozo
//             2016, Câmara Municipal de São Paulo

// token_list.js - a list of tokens in a TokenField.

Severity: Minor
Found in anubis/frontend/src/components/TokenField/token_list.js - About 2 hrs to fix

    Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            const styles = this.state.tokens.map(token => ({
                key: `token_${token.props.id}`,
                data: token,
                style: {
    Severity: Major
    Found in anubis/frontend/src/components/TokenField/token_list.js - About 2 hrs to fix

      Function getTokens has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getTokens() {
              this.tokenObjects = [];
      
              this.setState({tokens: this.props.expression.map((obj, i) => {
                  const key = obj.get('key');
      Severity: Minor
      Found in anubis/frontend/src/components/TokenField/token_list.js - About 1 hr to fix

        Function tokens has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                this.setState({tokens: this.props.expression.map((obj, i) => {
                    const key = obj.get('key');
                    let fieldset = this.props.fieldsets.get(key);
                    let values = obj.get('args', null);
                    const id = obj.get('index');
        Severity: Minor
        Found in anubis/frontend/src/components/TokenField/token_list.js - About 1 hr to fix

          Function connectToken has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              static connectToken(created, prev, next) {
                  if (prev == null) prev = I.fromJS({key: "__AND__"});
                  if (next == null) next = I.fromJS({key: "__AND__"});
          
                  const isCreatedUnitToken = !_.has(this.connectorMap,
          Severity: Minor
          Found in anubis/frontend/src/components/TokenField/token_list.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return _.zip(p.args, c.args).some(([pa, ca]) => pa != ca);
          Severity: Major
          Found in anubis/frontend/src/components/TokenField/token_list.js - About 30 mins to fix

            Function getTokens has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                getTokens() {
                    this.tokenObjects = [];
            
                    this.setState({tokens: this.props.expression.map((obj, i) => {
                        const key = obj.get('key');
            Severity: Minor
            Found in anubis/frontend/src/components/TokenField/token_list.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    fieldsets: IPropTypes.mapContains({
                        description: RPropTypes.string,
                        fields: IPropTypes.listOf(
                            IPropTypes.mapContains({
                                choices: IPropTypes.list,
            Severity: Major
            Found in anubis/frontend/src/components/TokenField/token_list.js and 1 other location - About 3 hrs to fix
            anubis/frontend/src/components/TokenField/editor_token.js on lines 56..68

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        IPropTypes.contains({
                            key: RPropTypes.string.isRequired,
                            index: RPropTypes.number.isRequired,
                            args: IPropTypes.listOf(RPropTypes.string),
                        }),
            Severity: Minor
            Found in anubis/frontend/src/components/TokenField/token_list.js and 1 other location - About 55 mins to fix
            anubis/frontend/src/components/TokenField/token.js on lines 88..92

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const prevRequiresConnector = !_.has(this.connectorMap,
                        prev.get('key')) || (prev.get('key') == "__RPARENS__");
            Severity: Minor
            Found in anubis/frontend/src/components/TokenField/token_list.js and 1 other location - About 35 mins to fix
            anubis/frontend/src/components/TokenField/token_list.js on lines 108..109

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    const nextRequiresConnector = !_.has(this.connectorMap,
                        next.get('key')) || (next.get('key') == "__LPARENS__");
            Severity: Minor
            Found in anubis/frontend/src/components/TokenField/token_list.js and 1 other location - About 35 mins to fix
            anubis/frontend/src/components/TokenField/token_list.js on lines 105..106

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status