code-lever/brigade-monitor-gem

View on GitHub

Showing 4 of 4 total issues

Method run has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def run
        api = Brigade::Monitor::API.new(@key, @log)

        @log.info("Monitoring #{@miners.length} miners")
        loop do
Severity: Minor
Found in lib/brigade/monitor/monitor.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method host_info has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def host_info(summary, version)
        sum = summary.body[0]
        ver = version.body[0]
        {
          host: @name,
Severity: Minor
Found in lib/brigade/monitor/fetcher.rb - About 1 hr to fix

    Method run has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run
            api = Brigade::Monitor::API.new(@key, @log)
    
            @log.info("Monitoring #{@miners.length} miners")
            loop do
    Severity: Minor
    Found in lib/brigade/monitor/monitor.rb - About 1 hr to fix

      Method pool_info has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def pool_info(pool)
              {
                index: pool['POOL'],
                url: pool['URL'],
                status: pool['Status'],
      Severity: Minor
      Found in lib/brigade/monitor/fetcher.rb - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language