code-lever/eagletree-log

View on GitHub

Showing 3 of 3 total issues

Class Session has 51 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Session

      # @return [Fixnum] this sessions number in the data file
      attr_reader :number

Severity: Major
Found in lib/eagletree/log/session.rb - About 7 hrs to fix

    Method initialize has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

          def initialize(uri)
            @sessions = []
    
            open(uri, 'r') do |file|
              @name = file.gets.strip
    Severity: Minor
    Found in lib/eagletree/log/file.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def initialize(uri)
            @sessions = []
    
            open(uri, 'r') do |file|
              @name = file.gets.strip
    Severity: Minor
    Found in lib/eagletree/log/file.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language