Sign upLogin

code-lever/ms-binary-resources

View on GitHub
Star

Showing 2 of 2 total issues

Class Reader has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Reader

      include Enumerable

      attr_reader :manager_magic, :manager_version, :manager_length, :resource_version, :resource_count, :type_count
Severity: Minor
Found in lib/ms/binary/resources/reader.rb - About 2 hrs to fix

    Method read_headers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def read_headers
        @manager_magic = read_uint32
        fail 'magic (%08X)' % manager_magic unless MAGIC_NUMBER == manager_magic

        @manager_version = read_uint32
    Severity: Minor
    Found in lib/ms/binary/resources/reader.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language