Showing 8 of 10 total issues
File AfricasTalkingGateway.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'rubygems'
require 'net/http'
require 'uri'
require 'json'
Method sendMessage has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)
post_body = {
'username' => @user_name,
'message' => message_,
'to' => recipients_, Method sendMessage has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)Method sendMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def sendMessage(recipients_, message_, from_ = nil, bulkSMSMode_ = 1, enqueue_ = 0, keyword_ = nil, linkId_ = nil, retryDurationInHours_ = nil)
post_body = {
'username' => @user_name,
'message' => message_,
'to' => recipients_, - Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method correct_user has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def correct_user
if current_user
@user = User.find(params[:id]) if params[:id]
unless current_user?(@user) || current_user.admin?
redirect_to user_path(current_user)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(id_, text_, from_, to_, linkId_, date_)Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(status_, number_, amount_, requestId_, errorMessage_, discount_)Method current_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def current_user
if (user_id = session[:user_id])
@current_user ||= User.find_by(id: user_id)
elsif (user_id = cookies.signed[:user_id])
user = User.find_by(id: user_id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"