Showing 209 of 252 total issues
Consider simplifying this complex logical expression. Open
Open
if ( forward && useCache ) {
// Seek `elem` from a previously-cached index
outerCache = parent[ expando ] || (parent[ expando ] = {});
cache = outerCache[ type ] || [];
nodeIndex = cache[0] === dirruns && cache[1];
Function init
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
init: function( selector, context, rootjQuery ) {
var match, elem;
// HANDLE: $(""), $(null), $(undefined), $(false)
if ( !selector ) {
Function domManip
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
domManip: function( args, callback, allowIntersection ) {
// Flatten any nested arrays
args = core_concat.apply( [], args );
Function ajaxConvert
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function ajaxConvert( s, response, jqXHR, isSuccess ) {
var conv2, current, conv, tmp, prev,
converters = {},
// Work with a copy of dataTypes in case we need to modify it for conversion
dataTypes = s.dataTypes.slice();
Function webSocket
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
$.fn.webSocket = function(config){
var target = this;
var pusher = config.pusher;
var currentChannel = null;
Function waitFor
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
function waitFor(testFx, onReady, timeOutMillis) {
var maxtimeOutMillis = timeOutMillis ? timeOutMillis : 3001, //< Default Max Timout is 3s
start = new Date().getTime(),
condition = false,
interval = setInterval(function() {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File rails.js
has 253 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
(function($, undefined) {
/**
* Unobtrusive scripting adapter for jQuery
* https://github.com/rails/jquery-ujs
Function remove
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
remove: function( elem, types, handler, selector, mappedTypes ) {
var j, handleObj, tmp,
origCount, t, events,
special, handlers, type,
namespaces, origType,
Consider simplifying this complex logical expression. Open
Open
if ( ( mappedTypes || origType === handleObj.origType ) &&
( !handler || handler.guid === handleObj.guid ) &&
( !tmp || tmp.test( handleObj.namespace ) ) &&
( !selector || selector === handleObj.selector || selector === "**" && handleObj.selector ) ) {
handlers.splice( j, 1 );
Function internalRemoveData
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function internalRemoveData( elem, name, pvt ) {
if ( !jQuery.acceptData( elem ) ) {
return;
}
Function internalData
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function internalData( elem, name, data, pvt /* Internal Use Only */ ){
if ( !jQuery.acceptData( elem ) ) {
return;
}
Function __initialize
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
WebSocket.__initialize = function() {
if (WebSocket.__flash) return;
if (WebSocket.__swfLocation) {
// For backword compatibility.
Function tokenize
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function tokenize( selector, parseOnly ) {
var matched, match, tokens, type,
soFar, groups, preFilters,
cached = tokenCache[ selector + " " ];
Function onTheSpot
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
$.fn.onTheSpot = function(config){
var defaults = {
submit : 'OK',
cancel : 'Cancel',
tooltip : '',
Function select
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function select( selector, context, results, seed ) {
var i, tokens, token, type, find,
match = tokenize( selector );
if ( !seed ) {
Function matcherFromTokens
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function matcherFromTokens( tokens ) {
var checkContext, matcher, j,
len = tokens.length,
leadingRelative = Expr.relative[ tokens[0].type ],
implicitRelative = leadingRelative || Expr.relative[" "],
Method add_member
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
Open
def add_member
render_login_error and return unless logged?
Room.with_room(params[:id], current_user) do |room|
render_room_not_found(params[:id]) and return if room.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function pagination
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
$.fn.pagination = function(config) {
var config = $.extend({
indicator : "",
content : "div"
}, config);
Consider simplifying this complex logical expression. Open
Open
if ( typeof value === "string" && !rnoInnerhtml.test( value ) &&
( jQuery.support.htmlSerialize || !rnoshimcache.test( value ) ) &&
( jQuery.support.leadingWhitespace || !rleadingWhitespace.test( value ) ) &&
!wrapMap[ ( rtagName.exec( value ) || ["", ""] )[1].toLowerCase() ] ) {
Function addCombinator
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function addCombinator( matcher, combinator, base ) {
var dir = combinator.dir,
checkNonElements = base && dir === "parentNode",
doneName = done++;