codeforamerica/oakland_answers

Function Converter has 430 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    Markdown.Converter = function () {
        var pluginHooks = this.hooks = new HookCollection();
        pluginHooks.addNoop("plainLinkText");  // given a URL that was encountered by itself (without markup), should return the link text that's to be given to this link
        pluginHooks.addNoop("preConversion");  // called with the orignal text as given to makeHtml. The result of this plugin hook is the actual markdown source that will be cooked
        pluginHooks.addNoop("postConversion"); // called with the final cooked HTML code. The result of this plugin hook is the actual output of makeHtml

File Markdown.Converter.js has 474 lines of code (exceeds 250 allowed). Consider refactoring.

Open

var Markdown;

if (typeof exports === "object" && typeof require === "function") // we're in a CommonJS (e.g. Node.js) module
    Markdown = exports;
else

Function writeAnchorTag has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function writeAnchorTag(wholeMatch, m1, m2, m3, m4, m5, m6, m7) {
            if (m7 == undefined) m7 = "";
            var whole_match = m1;
            var link_text = m2.replace(/:\/\//g, "~P"); // to prevent auto-linking withing the link. will be converted back after the auto-linker runs
            var link_id = m3.toLowerCase();

Function _FormParagraphs has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function _FormParagraphs(text, doNotUnhash) {
            //
            //  Params:
            //    $text - string to process with html <p> tags
            //

Function writeImageTag has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function writeImageTag(wholeMatch, m1, m2, m3, m4, m5, m6, m7) {
            var whole_match = m1;
            var alt_text = m2;
            var link_id = m3.toLowerCase();
            var url = m4;

Function _ProcessListItems has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        function _ProcessListItems(list_str, list_type) {
            //
            //  Process the contents of a single ordered or unordered list, splitting it
            //  into individual list items.
            //

Function writeImageTag has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        function writeImageTag(wholeMatch, m1, m2, m3, m4, m5, m6, m7) {

Function writeAnchorTag has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        function writeAnchorTag(wholeMatch, m1, m2, m3, m4, m5, m6, m7) {

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                if (g_urls.get(link_id) != undefined) {
                    url = g_urls.get(link_id);
                    if (g_titles.get(link_id) != undefined) {
                        title = g_titles.get(link_id);
                    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                if (g_urls.get(link_id) != undefined) {
                    url = g_urls.get(link_id);
                    if (g_titles.get(link_id) != undefined) {
                        title = g_titles.get(link_id);
                    }

• Read up
  Read up