Sign upLogin

codeforthailand/election-live

View on GitHub
Star

Showing 32 of 91 total issues

Consider simplifying this complex logical expression.
Open

    if (
      (!current.completed && previous.completed) ||
      (!current.data && previous.data)
    ) {
      return {
Severity: Major
Found in src/models/LiveDataSubscription.js - About 40 mins to fix

    Function DesktopScoreBarContainer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function DesktopScoreBarContainer({
  onTooltipClick = () => {},
  onTooltipOpen = () => {},
  onTooltipClose = () => {},
}) {
    Severity: Minor
    Found in src/components/DesktopScoreBarContainer.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ElectionMapContainer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function ElectionMapContainer({ currentZone }) {
  const summaryState = useSummaryData()
  const currentFilterName = useContext(ZoneFilterContext)
  const currentFilter = filters[currentFilterName]
  const [mapTip, setMapTip] = useState(null)
    Severity: Minor
    Found in src/components/ElectionMapContainer.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CandidateStatsRow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function CandidateStatsRow(props) {
  return (
    <div css={{ display: "flex", marginBottom: 15 }}>
      <div
        css={{
    Severity: Minor
    Found in src/components/CandidateStatsRow.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ZoneMasterView has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function ZoneMasterView({
  contentHeader,
  contentBody,
  currentZone,
  popup,
    Severity: Minor
    Found in src/components/ZoneMasterView.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WinnerInspector has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function WinnerInspector({
  noVotesWin,
  markColor,
  candidate,
  percentage,
    Severity: Minor
    Found in src/components/ElectionMapTooltip.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

      return (
    <ul css={{ listStyle: "none", margin: 0, marginTop: 10, padding: 0 }}>
      {zoneCandidates.map((candidate, index) => {
        const party = getPartyById(candidate.partyId)
        const percentage = Math.round((candidate.score / goodVotes) * 100) || 0
    Severity: Major
    Found in src/components/PerZoneView.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return partiesMap.get(id) || fail(`Party ID ${id} not found`)
      Severity: Major
      Found in src/models/information/index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return {
    completed: true,
    data: latestPointer.directory,
  }
        Severity: Major
        Found in src/models/LiveDataSubscription.js - About 30 mins to fix

          Function color has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            color(d) {
    // for testing
    // const index = Math.round(Math.random()*3)*2
    // const full = Math.random() > 0.5
    // const color = uniqueColors[index];
          Severity: Minor
          Found in src/components/ElectionMap.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function useInertState has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function useInertState(state) {
  const ref = useRef(state)
  const combine = (previous, current) => {
    if (
      (!current.completed && previous.completed) ||
          Severity: Minor
          Found in src/models/LiveDataSubscription.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function PerPartySearchPanelContainer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          export default function PerPartySearchPanelContainer({ partyId }) {
  const summaryState = useSummaryData()
  const totalVote = summaryState.completed ? (
    <AnimatedNumber value={summaryState.data.partyScoreMap[partyId] || 0}>
      {v => numberWithCommas(v)}
          Severity: Minor
          Found in src/components/PerPartySearchPanelContainer.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language