Sign upLogin

codenautas/backend-plus

View on GitHub
Star
ejemplos/encuesta.js

Summary

Maintainability
D
2 days
Test Coverage

Function addLoggedServices has 128 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    addLoggedServices(){
        super.addLoggedServices();
        var be = this;
        this.app.post('/info', function(req, res){
            res.end('ok!');
Severity: Major
Found in ejemplos/encuesta.js - About 5 hrs to fix

    File encuesta.js has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    "use strict";

const _ = require('lodash');
const util = require('util');
var readYaml = require('read-yaml-promise');
    Severity: Minor
    Found in ejemplos/encuesta.js - About 4 hrs to fix

      Function tipoCeldas has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          tipoCeldas(){
        //var tiposCeldas = {
        return {
            titulo:{
                completar: function completar(){
      Severity: Minor
      Found in ejemplos/encuesta.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function tipoCeldas has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          tipoCeldas(){
        //var tiposCeldas = {
        return {
            titulo:{
                completar: function completar(){
      Severity: Major
      Found in ejemplos/encuesta.js - About 2 hrs to fix

        Function completar has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        completar: function completar(celda, be, idFormulario, celdasAgregadas){
                    if(!celda.variable){
                        celda.variable = celda.pregunta.toLowerCase();
                    }
                    if(!celda.typeInfo && !celda.typeName && !celda["tipo-dato"] && !celda.opciones){
        Severity: Minor
        Found in ejemplos/encuesta.js - About 1 hr to fix

          Function readStructure has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              readStructure(fileName){
        var be = this;
        be.almacenVacio={
            formularios:{}
        };
          Severity: Minor
          Found in ejemplos/encuesta.js - About 1 hr to fix

            Function updateDatabase has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                updateDatabase(updateSql, parametros) {
        var id=parametros[0];
        var be=this;
        var client;
        return this.getDbClient().then(function(cli) {
            Severity: Minor
            Found in ejemplos/encuesta.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      return Promises.start(function(){
            return be.updateDatabase(sqlUpdate,parametros);
        }).then(function(result){
            res.end("recibi: "+JSON.stringify(parametros));
        },function(err){
              Severity: Major
              Found in ejemplos/encuesta.js and 1 other location - About 1 hr to fix
              ejemplos/encuesta.js on lines 272..279

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          be.updateDatabase(
                "UPDATE bep.datos SET estado=$2 WHERE id = $1 RETURNING contenido",
                [parametros.id, parametros.estado]
            ).then(function(result){
                res.end("recibi: "+JSON.stringify(parametros));
              Severity: Major
              Found in ejemplos/encuesta.js and 1 other location - About 1 hr to fix
              ejemplos/encuesta.js on lines 233..239

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status