Sign upLogin

codenothing/CSSCompressor

View on GitHub
Star
lib/rules/Strict ID.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function callback has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    callback: function( branch, compressor ) {
        if ( ! branch.selector || ! branch.parts || ! branch.parts.length ) {
            return;
        }
Severity: Major
Found in lib/rules/Strict ID.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if ( j !== 0 && i !== 0 ) {
                                compressor.log(
                                    "Promoting nested ID to selector front",
                                    branch.position
                                );
    Severity: Major
    Found in lib/rules/Strict ID.js - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              newCommaParts.forEach(function( a, i ) {
            parts.push.apply( parts, a );

            if ( i < newCommaParts.length - 1 ) {
                parts.push( ',' );
      Severity: Major
      Found in lib/rules/Strict ID.js and 1 other location - About 1 hr to fix
      lib/rules/Comma Repeats.js on lines 65..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              branch.parts.forEach(function( part ) {
            if ( part === ',' ) {
                commaParts.push( current );
                current = [];
            }
      Severity: Major
      Found in lib/rules/Strict ID.js and 1 other location - About 1 hr to fix
      lib/rules/Comma Repeats.js on lines 37..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status