Sign upLogin

codevise/pageflow

View on GitHub
Star
entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js

Summary

Maintainability
C
1 day
Test Coverage

Function createActions has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createActions(dispatch){
  return {
    playBlessed({via} = {}){
      media.mute(false);
      dispatch({type: PLAY, payload: {via}});
Severity: Major
Found in entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js - About 4 hrs to fix

    `` has 33 functions (exceeds 20 allowed). Consider refactoring.
    Open

      return {
    playBlessed({via} = {}){
      media.mute(false);
      dispatch({type: PLAY, payload: {via}});
    },
    Severity: Minor
    Found in entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          fadeOutAndPause(fadeDuration, {via} = {}){
      dispatch({type: FADE_OUT_AND_PAUSE, payload: {fadeDuration: fadeDuration, via}});
    },
      Severity: Minor
      Found in entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js and 1 other location - About 45 mins to fix
      entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js on lines 66..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          playAndFadeIn(fadeDuration, {via} = {}){
      dispatch({type: PLAY_AND_FADE_IN, payload: {fadeDuration: fadeDuration, via}});
    },
      Severity: Minor
      Found in entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js and 1 other location - About 45 mins to fix
      entry_types/scrolled/package/src/frontend/MediaPlayer/playerActions.js on lines 69..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status