Sign upLogin

codevise/pageflow

View on GitHub
Star
package/src/editor/views/PublishEntryView.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function save has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  save: function() {
    var publishedUntil = null;

    if (this.$el.hasClass('publishing')) {
      return;
Severity: Major
Found in package/src/editor/views/PublishEntryView.js - About 2 hrs to fix

    Function save has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      save: function() {
    var publishedUntil = null;

    if (this.$el.hasClass('publishing')) {
      return;
    Severity: Minor
    Found in package/src/editor/views/PublishEntryView.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      update: function() {
    this.$el.toggleClass('files_pending', this.model.get('uploading_files_count') > 0 || this.model.get('pending_files_count') > 0);
    this.$el.toggleClass('published', this.model.get('published'));

    this.ui.revisionsLink.attr('href', '/admin/entries/' + this.model.id);
    Severity: Minor
    Found in package/src/editor/views/PublishEntryView.js - About 1 hr to fix

      Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        update: function() {
    this.$el.toggleClass('files_pending', this.model.get('uploading_files_count') > 0 || this.model.get('pending_files_count') > 0);
    this.$el.toggleClass('published', this.model.get('published'));

    this.ui.revisionsLink.attr('href', '/admin/entries/' + this.model.id);
      Severity: Minor
      Found in package/src/editor/views/PublishEntryView.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status