coffeejunk/crypt19

View on GitHub

Showing 8 of 24 total issues

Method generate_key_schedule has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_key_schedule(k, key_bits, block_bits)
      tk = k[0..3][0..@key_words-1]  # using slice to get a copy instead of a reference
      key_sched = []
      (@rounds + 1).times { key_sched << [[], [], [], []] }
      t = 0
Severity: Minor
Found in lib/crypt/rijndael.rb - About 2 hrs to fix

    Method add_noise has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def add_noise(new_length)
          message = self
          usable_noisy_message_length = new_length / 9 * 8
          bitmap_size = new_length / 9
          remaining_bytes = new_length - usable_noisy_message_length - bitmap_size
    Severity: Minor
    Found in lib/crypt/noise.rb - About 1 hr to fix

      Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(user_key, key_bits = 256, block_bits = 128)
            case key_bits
              when 128
                @key_words = 4
              when 192
      Severity: Minor
      Found in lib/crypt/rijndael.rb - About 1 hr to fix

        Method add_noise has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def add_noise(new_length)
              message = self
              usable_noisy_message_length = new_length / 9 * 8
              bitmap_size = new_length / 9
              remaining_bytes = new_length - usable_noisy_message_length - bitmap_size
        Severity: Minor
        Found in lib/crypt/noise.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_key_schedule has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def generate_key_schedule(k, key_bits, block_bits)
              tk = k[0..3][0..@key_words-1]  # using slice to get a copy instead of a reference
              key_sched = []
              (@rounds + 1).times { key_sched << [[], [], [], []] }
              t = 0
        Severity: Minor
        Found in lib/crypt/rijndael.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(key128, mode)
              # IDEA is subject to attack unless the key is sufficiently random, so we
              # take an MD5 digest of a variable-length passphrase to ensure a solid key
              if (key128.class == String)
                digest = Digest::MD5.digest(key128)
        Severity: Minor
        Found in lib/crypt/idea.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(user_key, key_bits = 256, block_bits = 128)
              case key_bits
                when 128
                  @key_words = 4
                when 192
        Severity: Minor
        Found in lib/crypt/rijndael.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method generate_encryption_subkeys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def generate_encryption_subkeys(key)
              encrypt_keys = []
              encrypt_keys[0..7] = key.dup
              8.upto(51) { |i|
                a = ((i + 1) % 8 > 0) ? (i-7)  : (i-15)
        Severity: Minor
        Found in lib/crypt/idea.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language