Sign upLogin

colonizers/colonizers

View on GitHub
Star
packages/colonizers-client/lib/game/hex-corner.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function buildCity has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildCity(player) {
    super.buildCity(player);

    if (this.drawing) {
      this.drawing.destroy();
Severity: Minor
Found in packages/colonizers-client/lib/game/hex-corner.js - About 1 hr to fix

    Function buildSettlement has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      buildSettlement(player) {
    super.buildSettlement(player);

    if (this.drawing) {
      this.drawing.destroy();
    Severity: Minor
    Found in packages/colonizers-client/lib/game/hex-corner.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        show(player) {
    if (this.isBuildable) {
      this.drawing.fill(player.color);
      this.drawing.opacity(0.4);
      this.group.show();
      Severity: Major
      Found in packages/colonizers-client/lib/game/hex-corner.js and 1 other location - About 2 hrs to fix
      packages/colonizers-client/lib/game/hex-edge.js on lines 74..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.drawing.on('mouseout', () => {
      $(this.drawing.getStage().container()).removeClass('clickable');
    });
      Severity: Minor
      Found in packages/colonizers-client/lib/game/hex-corner.js and 1 other location - About 55 mins to fix
      packages/colonizers-client/lib/game/hex-corner.js on lines 33..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.drawing.on('mouseover', () => {
      $(this.drawing.getStage().container()).addClass('clickable');
    });
      Severity: Minor
      Found in packages/colonizers-client/lib/game/hex-corner.js and 1 other location - About 55 mins to fix
      packages/colonizers-client/lib/game/hex-corner.js on lines 37..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        constructor(factory, options) {
    super(factory, options);
    emitter(this);
    this.render(options);
    this.hookupEvents();
      Severity: Minor
      Found in packages/colonizers-client/lib/game/hex-corner.js and 1 other location - About 35 mins to fix
      packages/colonizers-client/lib/game/hex-edge.js on lines 10..15

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status