Sign upLogin

comsave/salesforce-outbound-message-bundle

View on GitHub
Star

Showing 5 of 5 total issues

Function updateWithDocument has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateWithDocument($document, $newDocument, ?array $allowedProperties = [], ?array $ignoredProperties = [])
    {
        $classReflection = new ReflectionClass($newDocument);
        $allowedProperties = $allowedProperties ?: [];
        $ignoredProperties = $ignoredProperties ?: [];
Severity: Minor
Found in src/Comsave/SalesforceOutboundMessageBundle/Services/DocumentUpdater.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process($sObject)
    {
        if (!is_object($sObject)) {
            throw new InvalidRequestException();
        }
Severity: Minor
Found in src/Comsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandler.php - About 1 hr to fix

    Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            DocumentManager $documentManager,
        Mapper $mapper,
        DocumentUpdater $documentUpdater,
        EventDispatcherInterface $eventDispatcher,
        string $documentClassName,
    Severity: Major
    Found in src/Comsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandler.php - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              DocumentManager $documentManager,
        Mapper $mapper,
        DocumentUpdater $documentUpdater,
        EventDispatcherInterface $eventDispatcher,
        OutboundMessageBeforeFlushEventBuilder $outboundMessageBeforeFlushEventBuilder,
      Severity: Major
      Found in src/Comsave/SalesforceOutboundMessageBundle/Services/Builder/SoapRequestHandlerBuilder.php - About 1 hr to fix

        Function process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function process($sObject)
    {
        if (!is_object($sObject)) {
            throw new InvalidRequestException();
        }
        Severity: Minor
        Found in src/Comsave/SalesforceOutboundMessageBundle/Services/RequestHandler/SoapRequestHandler.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language