Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/assets/javascripts/active_scaffold/default/rico_corner.js

Summary

Maintainability
F
4 days
Test Coverage

File rico_corner.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
  *
  *  Copyright 2005 Sabre Airline Solutions
  *
  *  Licensed under the Apache License, Version 2.0 (the "License"); you may not use this
Severity: Minor
Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 2 hrs to fix

    Corner has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    Rico.Corner = {

   round: function(e, options) {
      var e = $(e);
      this._setOptions(options);
    Severity: Minor
    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 2 hrs to fix

      Function _createCornerSlice has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

         _createCornerSlice: function(color,bgColor, n, position) {
      var slice = document.createElement("span");

      var inStyle = slice.style;
      inStyle.backgroundColor = color;
      Severity: Minor
      Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 1 hr to fix

        Function RGBtoHSB has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        Rico.Color.RGBtoHSB = function(red, green, blue) {
        var hue, saturation, brightness;
        var max = Math.max(red, green, blue), min = Math.min(red, green, blue);
        var delta = max - min;
        brightness = max / 255;
        Severity: Minor
        Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

              return new Rico.Color(255,255,255);
        Severity: Major
        Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return "";
          Severity: Major
          Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return "";
            Severity: Major
            Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                       return transparentBorderSizes[n];
              Severity: Major
              Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 0;
                Severity: Major
                Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                           return marginSizes[n];
                  Severity: Major
                  Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 30 mins to fix

                    Function _borderSize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                       _borderSize: function(n) {
      var transparentBorderSizes = [ 5, 3, 2, 1 ];
      var blendedBorderSizes     = [ 2, 1, 1, 1 ];
      var compactBorderSizes     = [ 1, 0 ];
      var actualBorderSizes      = [ 0, 2, 0, 0 ];
                    Severity: Minor
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                       _whichSideBottom: function() {
      if ( this._hasString(this.options.corners, "all", "bottom") )
         return "";

      if ( this.options.corners.indexOf("bl")>=0 && this.options.corners.indexOf("br")>=0 )
                    Severity: Major
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 1 other location - About 5 hrs to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 253..265

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 144.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                       _whichSideTop: function() {
      if ( this._hasString(this.options.corners, "all", "top") )
         return "";

      if ( this.options.corners.indexOf("tl") >= 0 && this.options.corners.indexOf("tr") >= 0 )
                    Severity: Major
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 1 other location - About 5 hrs to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 267..279

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 144.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          if ( whichSide == "left" ) {
         el.style.marginLeft = marginSize + "px"; el.style.marginRight = "0px";
      }
      else if ( whichSide == "right" ) {
         el.style.marginRight = marginSize + "px"; el.style.marginLeft  = "0px";
                    Severity: Major
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 1 other location - About 4 hrs to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 311..319

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 133.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          if ( whichSide == "left" ) {
         el.style.borderLeftWidth = borderSize + "px"; el.style.borderRightWidth = "0px";
      }
      else if ( whichSide == "right" ) {
         el.style.borderRightWidth = borderSize + "px"; el.style.borderLeftWidth  = "0px";
                    Severity: Major
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 1 other location - About 4 hrs to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 297..305

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 133.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                          this.rgb.g = Math.floor((this.rgb.g + other.rgb.g)/2);
                    Severity: Minor
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 2 other locations - About 35 mins to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 33..33
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 35..35

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                          this.rgb.b = Math.floor((this.rgb.b + other.rgb.b)/2);
                    Severity: Minor
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 2 other locations - About 35 mins to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 33..33
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 34..34

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                          this.rgb.r = Math.floor((this.rgb.r + other.rgb.r)/2);
                    Severity: Minor
                    Found in rails/app/assets/javascripts/active_scaffold/default/rico_corner.js and 2 other locations - About 35 mins to fix
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 34..34
                    rails/app/assets/javascripts/active_scaffold/default/rico_corner.js on lines 35..35

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status